feat: warn user on login if mount points are incorrect #3514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbtrystram
requested changes
May 20, 2025
| . /usr/lib/console-login-helper-messages/libutil.sh | ||
| . /usr/lib/console-login-helper-messages/issue.defs | ||
|
|
||
| OUTDIR="${RUN_SNIPPETS}" |
There was a problem hiding this comment.
This variable is not set.
OUTDIR=/run/motd.d/
There was a problem hiding this comment.
the OUTDIR is populated with the RUN_SNIPPETS that is sourced from the /usr/lib/console-login-helper-messages/issue.defs file having this logic inside it
private_issue_snippets_path="/run/${PKG_NAME}/issue.d"
# Since util-linux 2.35, `agetty` has been able to display files
# from additional locations like `/run/issue` and `/run/issue.d`
# if `/etc/issue` does not exist.
# We are currently dropping issue snippets in `/etc/issue.d` (instead
# of `/run/issue.d`) because of a systemd tmpfile that makes removal of
# `/etc/issue` virtually impossible.
# https://github.com/systemd/systemd/commit/062666c7c452711f3e38efdec0c2b952ced64d06
# In the future, we would ideally drop into `/run/issue.d`; this would
# require either users configure the `--issue-file` option in `agetty`,
# or not use `/etc/issue`.
public_issue_snippets_path="/etc/issue.d"
if [ "${USE_PUBLIC_RUN_DIR}" == "false" ]; then
RUN_SNIPPETS="${private_issue_snippets_path}"
else
RUN_SNIPPETS="${public_issue_snippets_path}"
fiIt's important that / and /sysroot are mounted read-only and that the root filesystem uses ComposeFS to maintain system immutability. This change adds a warning to notify users if any of these conditions are not met.
jbtrystram
reviewed
May 20, 2025
| fi | ||
|
|
||
| # Check if / is mounted read-only | ||
| root_options=$(findmnt / --json | jq -r '.filesystems[].options') |
There was a problem hiding this comment.
use the same jq as above, or better yet, save the output for the whole root object then reuse that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coreos/fedora-coreos-tracker#1954