8000 Backport of CORDA-2998 fix network builder (#5265) by szymonsztuka · Pull Request #5270 · corda/corda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Backport of CORDA-2998 fix network builder (#5265) #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2019
Merged

Backport of CORDA-2998 fix network builder (#5265) #5270

merged 3 commits into from
Jul 9, 2019

Conversation

szymonsztuka
Copy link
Contributor
@szymonsztuka szymonsztuka commented Jul 2, 2019 •
edited
Loading

CORDA-2998 fix network builder

(cherry picked from commit f89008c)

This is a follow-up of already merged PR ofr branch 4 #5205, however this PR (as a backport from master) standardizes the tool name as 'Network Builder' + carry on more improvments.

This is prerequsites to release Network Builder tool v4.2 (https://r3-cev.atlassian.net/browse/CORDA-2928).

Manually tested by ./gradlew tools:network-builder:publishToMavenLocal
and then using ~/.m2/repository/net/corda/corda-tools-network-builder/4.1/corda-tools-network-builder-4.1.jar.
Following the updated docs: https://github.com/corda/corda/blob/5eaa7262a340415369f043b9442143e15c769571/docs/source/network-builder.rst
and https://r3-cev.atlassian.net/browse/R3T-3502.

Additional test:

docker exec -it  c69cfec0d701  bash
corda@c69cfec0d701:~$ cd bin
corda@c69cfec0d701:~/bin$ java -jar corda.jar --version
Version: 4.1
Revision: c11f6c15f71ac47b715e8e1b56ff5159b3730bdc
Platform Version: 4
Vendor: Corda Open Source

CORDA-2998 fix network builder (#5265)
c29c427 
CORDA-2998 fix network builder

(cherry picked from commit f89008c)
@szymonsztuka szymonsztuka added this to the Corda 4.2 milestone Jul 2, 2019
@szymonsztuka szymonsztuka requested a review from fenryka July 3, 2019 08:48
@szymonsztuka szymonsztuka modified the milestones: Corda 4.2, Corda 4.1 Jul 9, 2019
@szymonsztuka szymonsztuka requested review from josecoll and removed request for fenryka July 9, 2019 09:22
josecoll
josecoll approved these changes Jul 9, 2019
View reviewed changes
Copy link
@josecoll josecoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on basis of prior approval on master + update to reference corda-zulu-4.1 as discussed.

@josecoll josecoll merged commit c6262b6 into release/4 Jul 9, 2019
@szymonsztuka szymonsztuka deleted the backport/release-4-CORDA-2998-network-builder branch July 12, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecoll josecoll josecoll approved these changes

Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
Corda 4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@szymonsztuka @josecoll
0