8000 feat: add a code of conduct, security file and pr template by MuntasirSZN · Pull Request #129 · cordx56/rustowl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add a code of conduct, security file and pr template #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

feat: add a code of conduct, security file and pr template #129

merged 2 commits into from
May 6, 2025

Conversation

MuntasirSZN
Copy link
Collaborator
@MuntasirSZN MuntasirSZN commented May 5, 2025 •
edited
Loading

Just copied contributor covenant and made a security.md file, with a overall pr template. Not required but its the community standard, whatsoever.

Also a contributing.md should be created as not everyone is a expert, they need to setup their environment with stable rust rustc bootstrap etc clippy fmt. I won't write that as you know more about this project then me.

@MuntasirSZN MuntasirSZN requested a review from cordx56 May 5, 2025 14:33
@MuntasirSZN MuntasirSZN changed the title feat: add a code of conduct and security file feat: add a code of conduct, security file and pr template May 5, 2025
cordx56
cordx56 approved these changes May 6, 2025
View reviewed changes
Copy link
Owner
@cordx56 cordx56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will write CONTRIBUTING.md.

@cordx56 cordx56 merged commit a8ba67a into cordx56:main May 6, 2025
3 checks passed
@MuntasirSZN MuntasirSZN deleted the feat/community-standards branch May 6, 2025 01:46
@MuntasirSZN
Copy link
Collaborator Author
MuntasirSZN commented May 6, 2025 •
edited
Loading

@cordx56 Uhh shit in code of conduct i added my email can you change that to yours? Go to enforcement part you will see.

@cordx56
Copy link
Owner 8000
cordx56 commented May 6, 2025

fixed and pushed to main.

@MuntasirSZN
Copy link
Collaborator Author

@cordx56 contributing file should be in root.

@cordx56
Copy link
Owner
cordx56 commented May 6, 2025

GitHub docs tells that those docs can be located in docs dir. It shouldn't be? I'd like to locate them in docs dir and link from README.md. (Also, I would like to organize the contents of README)

@MuntasirSZN
Copy link
Collaborator Author
MuntasirSZN commented May 6, 2025 •
edited
Loading

GitHub docs tells that those docs can be located in docs dir. It shouldn't be? I'd like to locate them in docs dir and link from README.md. (Also, I would like to organize the contents of README)

Doing the above will not add a contributing tab. @cordx56

@cordx56
Copy link
Owner
cordx56 commented May 6, 2025

I moved but there is no contributing tab. Any mistakes?

@MuntasirSZN
Copy link
Collaborator Author
MuntasirSZN commented May 6, 2025 •
edited
Loading

I moved but there is no contributing tab. Any mistakes?

I misspoke revert that commit please sorry 😥 @cordx56

@cordx56
Copy link
Owner
cordx56 commented May 6, 2025

May I move code of conduct and security into docs? GitHub docs says that docs dir also checked.

@MuntasirSZN
Copy link
Collaborator Author
MuntasirSZN commented May 6, 2025 •
edited
Loading

May I move code of conduct and security into docs? GitHub docs says that docs dir also checked.

Then ok! Though most of the big projects put them in root, but it doesn't matter. @cordx56
cordx56 reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cordx56 cordx56 cordx56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuntasirSZN @cordx56
0