This repository was archived by the owner on Oct 24, 2024. It is now read-only.
8000
ADCIO-2907) feat: pub-sub add-to-cart #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverlish
reviewed
Mar 21, 2024
NaGyeong-Park
previously approved these changes
Mar 25, 2024
Comment on lines
+41
to
+44
| const data = decodeURI(arg) | ||
| .split("&") | ||
| .reduce((acc, cur) => { | ||
| const [key, value] = cur.split("="); |
There was a problem hiding this comment.
URL 객체써서 요렇게 파싱하는건 어떠세요
const data = new URL(arg);
Object.fromEntries(data.searchParams)
neverlish
reviewed
Mar 25, 2024
neverlish
reviewed
Mar 25, 2024
| @@ -102,6 +99,7 @@ export class Cafe24API implements ClientAPI { | |||
| id: order_id, | |||
| products: order_product.map((product) => ({ | |||
| idOnStore: `${product.product_no}`, | |||
| // categoryIdOnStore: `${product.category_no_1}`, | |||
There was a problem hiding this comment.
혹시 여기가 주석처리된 이유가 있을까요? 주석처리된 상태로 남겨둔다면, 간단히 이유를 남겨줘도 좋을 듯 해요
There was a problem hiding this comment.
우리가 원하는 카테고리(구매 플로우에서 처음에 접근한 상품분류 페이지)가 맞는지 확실하지 않아서 주석처리했습니다.
테스트해보고 주석 유지 여부 결정할게요. 아무래도 구매다보니 테스트가 쉽지 않네요 ..ㅎㅎ
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Jira Ticket Number
ADCIO-2907
♻️ Current situation
💡 Proposed solution
new AddToCartEvent(cart).dispatch()같은 방법으로 간단하게 카트 이벤트를 pub합니다.action_basket함수를 wrapping 했습니다.⚙️ Release Notes
➕ Additional Information
action_basket함수 관련 수정이 있을 경우, 장바구니 수집에 문제가 생길 수 있습니다.🧪 Testing
🧑💻 Reviewer Nudging
✅ Checklist
📚 TODO