8000 [CORL-2547]: fix unmark all keyboard shortcut not working by kabeaty · Pull Request #3921 · coralproject/talk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CORL-2547]: fix unmark all keyboard shortcut not working #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2022
Merged

[CORL-2547]: fix unmark all keyboard shortcut not working #3921

merged 1 commit into from
Apr 21, 2022

Conversation

kabeaty
Copy link
Contributor
@kabeaty kabeaty commented Apr 21, 2022

What does this PR do?

These changes make it so that the unmark all keyboard shortcut is working again. We needed to update to look for unseen comments in the root, as we updated to do throughout the rest of the keyboard shortcuts.

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

Mark sure that COMMENT_SEEN feature flag is enabled. Use shift + a to unmark all comments and see that they are unmarked. Also can test out that the mobile button works to unmark all comments with these changes.

How do we deploy this PR?

@netlify
Copy link
netlify bot commented Apr 21, 2022 •
edited
Loading

✅ Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 1f37f67
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/626182f8a02fed00090f2b6d

@kabeaty kabeaty requested a review from tessalt April 21, 2022 16:15
@tessalt tessalt added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Apr 21, 2022
@kodiakhq kodiakhq bot merged commit 68ddfc1 into develop Apr 21, 2022
@kodiakhq kodiakhq bot deleted the bug/CORL-2547-unmark-all-ios-broken branch April 21, 2022 16:28
kodiakhq bot pushed a commit that referenced this pull request Apr 21, 2022
@tessalt @kabeaty
v7.0.1 (#3923)
3de1271 
* look for notSeenComments in root (#3921)

* bump 7.0.1 (#3922)

Co-authored-by: Kathryn Beaty <kathryn.beaty@voxmedia.com>
tessalt pushed a commit that referenced this pull request May 9, 2022
@kabeaty @tessalt
look for notSeenComments in root (#3921)
ccb42dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tessalt tessalt tessalt approved these changes

Assignees
No one assigned
Labels
🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kabeaty @tessalt
0