8000 Custom CSS Fix by wyattjoh · Pull Request #1670 · coralproject/talk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Custom CSS Fix #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2018
Merged

Custom CSS Fix #1670

merged 2 commits into from
May 31, 2018

Conversation

wyattjoh
Copy link
Collaborator

What does this PR do?

  • Fix CSS loading order bug
  • Remove custom CSS from admin page

How do I test this PR?

  1. Create a custom CSS file that changes something without !important.
  2. Refresh the stream, notice the change.
  3. Refresh the admin, notice no change!

@wyattjoh wyattjoh added the bug label May 31, 2018
@kgardnr kgardnr self-requested a review May 31, 2018 17:30
@cvle
Copy link
Contributor
cvle commented May 31, 2018

Does admin needs the custom css?

@kgardnr kgardnr added this to the v4.4.2 milestone May 31, 2018
@wyattjoh
Copy link
Collaborator Author

Most newsrooms @cvle that I've tested their CSS on admin broke everything, as it isn't scoped to the CSS of the embed stream.

@wyattjoh wyattjoh merged commit 375ef09 into master May 31, 2018
@wyattjoh wyattjoh deleted the templates branch May 31, 2018 17:50
@kgardnr kgardnr modified the milestones: v4.4.2, v4.4.3 May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0