fix two github action workflow issues #2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linked action has been removed in podman [1] and such it will always fail. [1] containers/podman@130bb21 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
LGTM |
mtrmac
reviewed
Apr 10, 2025
So I wondered why our email workflow only reported things for podman... It seems the secrets: inherit is broken and no longer working, I see all jobs on all repos failing with: Error when evaluating 'secrets'. .github/workflows/check_cirrus_cron.yml (Line: 19, Col: 11): Secret SECRET_CIRRUS_API_KEY is required, but not provided while calling. This makes no sense to me I doubled checked the names, nothing change don our side and it is consitent for all projects. Interestingly this same thing passed on March 10 and 11 (on all repos) but failed before and after this as well. Per[1] we are not alone, anyway let's try to get this working again even if it means more duplication. [1] actions/runner#2709 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
Triggered the action manually, it worked! Now you should have an email that shows errors on two branches |
|
Thanks, I did get that email. And I was thinking c/image is doing so well :) |
|
Well that is what made me look into these things, we only got podman mails but no other repo a single flake (considering we disabled the auto rerun flake action just recently) so that couldn't be right to me and sure enough here we are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see both commits, the first one is obvious, the second one I like to see if that works on this repo before making PRs against all the other that use this cirrus rerun action with the same change
.github: check_cirrus_cron work around github bug
So I wondered why our email workflow only reported things for podman...
It seems the secrets: inherit is broken and no longer working, I see all
jobs on all repos failing with:
Error when evaluating 'secrets'. .github/workflows/check_cirrus_cron.yml (Line: 19, Col: 11): Secret SECRET_CIRRUS_API_KEY is required, but not provided while calling.
This makes no sense to me I doubled checked the names, nothing change
don our side and it is consitent for all projects. Interestingly this
same thing passed on March 10 and 11 (on all repos) but failed before
and after this as well.
Per[1] we are not alone, anyway let's try to get this working again even
if it means more duplication.
[1] actions/runner#2709