8000 chore(deps): update dependency golangci/golangci-lint to v2 by renovate[bot] · Pull Request #2804 · containers/image · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(deps): update dependency golangci/golangci-lint to v2 #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2025
Merged

chore(deps): update dependency golangci/golangci-lint to v2 #2804

merged 5 commits into from
Mar 26, 2025

Conversation

renovate[bot]
Copy link
Contributor
@renovate renovate bot commented Mar 24, 2025

This PR contains the following updates:

Package Update Change
golangci/golangci-lint major 1.64.8 -> 2.0.0

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v2.0.0

Compare Source

  1. Enhancements
  2. New linters/formatters
  3. Linters new features
    • ⚠️ Merge staticcheck, stylecheck, gosimple into one linter (staticcheck) (cf. Migration guide)
    • go-critic: from 0.12.0 to 0.13.0
    • gomodguard: from 1.3.5 to 1.4.1 (block explicit indirect dependencies)
    • nilnil: from 1.0.1 to 1.1.0 (new option: only-two)
    • perfsprint: from 0.8.2 to 0.9.1 (checker name in the diagnostic message)
    • staticcheck: new quickfix set of rules
    • testifylint: from 1.5.2 to 1.6.0 (new options: equal-values, suite-method-signature, require-string-msg)
    • wsl: from 4.5.0 to 4.6.0 (new option: allow-cuddle-used-in-block)
  4. Linters bug fixes
    • bidichk: from 0.3.2 to 0.3.3
    • errchkjson: from 0.4.0 to 0.4.1
    • errname: from 1.0.0 to 1.1.0
    • funlen: fix ignore-comments option
    • gci: from 0.13.5 to 0.13.6
    • gosmopolitan: from 1.2.2 to 1.3.0
    • inamedparam: from 0.1.3 to 0.2.0
    • intrange: from 0.3.0 to 0.3.1
    • protogetter: from 0.3.9 to 0.3.12
    • unparam: from 8a5130c to 0df0534
  5. Misc.
    • 🧹 Configuration options renaming (cf. Migration guide)
    • 🧹 Remove options (cf. Migration guide)
    • 🧹 Remove flags (cf. Migration guide)
    • 🧹 Remove alternative names (cf. Migration guide)
    • 🧹 Remove or replace deprecated elements (cf. Migration guide)
    • Adds an option to display some commands as JSON:
      • golangci-lint config path --json
      • golangci-lint help linters --json
      • golangci-lint help formatters --json
      • golangci-lint linters --json
      • golangci-lint formatters --json
      • golangci-lint version --json
  6. Documentation

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Mar 24, 2025
@renovate renovate bot force-pushed the renovate/golangci-golangci-lint-2.x branch from 733de6c to 70d120a Compare March 24, 2025 18:30
@mtrmac mtrmac force-pushed the renovate/golangci-golangci-lint-2.x branch from 47ddce0 to 820507c Compare March 24, 2025 19:31
@renovate Renovate
Copy link
Contributor Author
renovate bot commented Mar 24, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@mtrmac
Copy link
Collaborator
mtrmac commented Mar 25, 2025

@flouthoc could you take a look, please? This is mostly a dumb dependency update, but the warning changes are large enough that I’d prefer not to merge this with no review at all.

flouthoc
flouthoc reviewed Mar 26, 2025
View reviewed changes
internal/image/memory.go Outdated
< 8000 span class="Button-label"> Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this commit reduces readability.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — that’s now consensus enough that I’d prefer to this, either silencing the warnings or restructuring to avoid them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need an extra data point to make a decision, I'm disabling QF1008 in couple of other repos.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have disabled QF1008 now — if we embed a field anonymously, that’s either for JSON etc. decoding, or as a mixing for a partial interface implementation. In both cases, being explicit about the embedded field makes it easier to audit code for correctly handling all fields of both the embedder and the embedder.

flouthoc
flouthoc approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor
@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrmac mtrmac marked this pull request as draft March 26, 2025 16:20
kolyshkin
kolyshkin reviewed Mar 26, 2025
View reviewed changes
.golangci.yml Outdated
@@ -1,16 +1,21 @@
---
version: "2"
run:
concurrency: 6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove concurrency while at it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

kolyshkin
kolyshkin reviewed Mar 26, 2025
View reviewed changes
.golangci.yml Outdated
staticcheck:
checks: ["all", "-ST1000", "-ST1003", "-ST1016", "-ST1020", "-ST1021", "-ST1022", "-ST1005"] # golangci-lint's default, we add -ST1005
exclusions:
generated: lax
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have strict here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t actually have any generated code, and thus we have no opinion — we can drop this and let the linter’s default do the best it can, maybe improving over time.

@mtrmac mtrmac force-pushed the renovate/golangci-golangci-lint-2.x branch from 820507c to 5af10c8 Compare March 26, 2025 19:09
mtrmac and others added 5 commits March 26, 2025 20:17
@mtrmac
Fix "QF1001: could apply De Morgan's law"
4d10eba 
Should not change behavior

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Fix "QF1007: could merge conditional assignment into variable declara…
ae3a9aa 
…tion"

... actually inline the code into the only user.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Fix "QF1009: probably want to use time.Time.Equal instead"
ccf6033 
time.IsZero() is probably a bit slower, but relying on an explicit
API should be better long-term.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
8000 Fix "QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(…
6b18993 
…...))"

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@renovate @mtrmac
chore(deps): update dependency golangci/golangci-lint to v2
ff238bc 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac force-pushed the renovate/golangci-golangci-lint-2.x branch from 5af10c8 to ff238bc Compare March 26, 2025 19:18
@mtrmac mtrmac marked this pull request as ready for review March 26, 2025 19:18
kolyshkin
kolyshkin approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor
@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrmac mtrmac merged commit 8162450 into main Mar 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac left review comments

@kolyshkin kolyshkin kolyshkin approved these changes

@flouthoc flouthoc flouthoc approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtrmac @kolyshkin @flouthoc
0