pkg/oci: add WithAppendAdditionalGIDs option, add fast-path to WithAppendAdditionalGroups #11974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows setting additional GIDs for the process, similar to WithAppendAdditionalGroups, but without involving resolving group-name to GIDs. This allows adding additional groups in situations where the GIDs have already been resolved. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
768de42 to
c65352c
Compare
WithAppendAdditionalGroups was unconditionally resolving group-names and, because of that, requiring `/etc/group` to be present (and a read-only mount to be created). In situations where all groups passed are numeric IDs, we can skip those steps, and add the GIDs directly without performing a lookup. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
c65352c to
cab1d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/oci: add WithAppendAdditionalGIDs option
This option allows setting additional GIDs for the process, similar to
WithAppendAdditionalGroups, but without involving resolving group-name
to GIDs. This allows adding additional groups in situations where the
GIDs have already been resolved.
pkg/oci: add fast-path to WithAppendAdditionalGroups option
WithAppendAdditionalGroups was unconditionally resolving group-names and,
because of that, requiring
/etc/groupto be present (and a read-onlymount to be created).
In situations where all groups passed are numeric IDs, we can skip those
steps, and add the GIDs directly without performing a lookup.