chore: remove go version specific code #11857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
dbc19ad to
f194d8c
Compare
|
/cc @fuweid @thaJeztah since you guys contributed some of these code and may have more context on them. I think we should be good to delete them given we have go 1.24.3 as the min version? |
There was a problem hiding this comment.
Pull Request Overview
This PR removes Go version–specific workarounds now that Go 1.24 is the minimum supported version, consolidates duplicate logic, and cleans up legacy test files.
- Drop the Go 1.23 “double close” PIDFD workaround and its
runtimeimport inunshare_linux.go. - Standardize on
fs.FileInfoToDirEntryand remove Go 1.16/1.17 compatibility tests. - Simplify the mount package’s
getUsernsFDby removing legacy build tags and updating PIDFD logic.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/sys/unshare_linux.go | Removed runtime import and Go 1.23 PIDFD dup-close logic |
| pkg/oci/utils_unix_test.go | Replaced custom fileInfoToDirEntry with fs.FileInfoToDirEntry |
| pkg/oci/utils_unix_go117_test.go | Deleted Go 1.17–specific compatibility shim |
| pkg/oci/utils_unix_go116_test.go | Deleted Go 1.16–specific compatibility shim |
| core/mount/mount_idmapped_utils_linux_go122.go | Deleted Go 1.22–specific mount helpers |
| core/mount/mount_idmapped_utils_linux.go | Updated getUsernsFD to always use PIDFD, removed outdated checks |
fuweid
approved these changes
Jun 9, 2025
estesp
approved these changes
Jun 9, 2025
hmm this issue shows up again |
thaJeztah
reviewed
Jun 10, 2025
Now that we have 1.24.x as go min version, I think we can remove this go code specific to a lower version. Signed-off-by: Jin Dong <djdongjin95@gmail.com>
f194d8c to
734d52c
Compare
thaJeztah
approved these changes
Jun 13, 2025
estesp
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have 1.24.x as go min version, I think we can remove this go code specific to a lower
version.
Depends on