bug: fix status-code for store not found #660
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655
Summary
This MR fixes an issue where attempting to export a non-existing store returned an incorrect status code (500 instead of 404). The response now correctly returns a 404 status code with a message indicating that the store was not found.
Changes
Explanation:
When an error is thrown in Fastify (like NotFoundError), the framework’s default error handler automatically intercepts it. If the error object includes a statusCode property, Fastify will set the response’s status code to this value. This means that by simply throwing an error with a custom statusCode, Fastify will correctly format and send the response based on the error's properties without needing extra configuration.
see docs
Example Response
{ "code": "FST_ERR_NOT_FOUND", "name": "NotFoundError", "message": "store \"mainStore\" not found", "statusCode": 404 }