8000 Enable Windows Py27 tests by mlline00 · Pull Request #9863 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable Windows Py27 tests #9863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2020
Merged

Enable Windows Py27 tests #9863

merged 3 commits into from
Apr 26, 2020

Conversation

mlline00
Copy link
Contributor

This PR enables Python 2.7 tests on Windows.

Notes:

  • test_create.test_conda_downgrade throws a C runtime error which pops a modal dialog on the host and halts test execution. Spent some time trying trying to resolve, but made no progress. Restoring the skip for 2.7 on Windows seemed like a reasonable approach. Specific error message is "R6034 An application has made an attempt to load the C runtime library incorrectly. Please contact the application's support team for more information".
  • The combination of channels in the intsall step created a non-functional pytest environment. The default settings work. Did not dig into which channel caused the issue.

@mlline00
Enable Windows Py27 tests
4fa6634 
appvevyor.yml
- Set PYTHONIOENCODING=UTF-8 environment variable for pip
- Remove conda-canary and conda-forge channels from install

test_solve.py
- Test bitness using platform module ; sys.platform is always win32 on Windows

test_create.py
- Skip test_conda_downgrade on windows py27. I spent some time trying to identify root issue, but ¯\_(ツ)_/¯. There is alot of history around this particular test, so I don't feel too bad about skipping instead of solving.
@mlline00 mlline00 requested a review from a team as a code owner April 20, 2020 12:41
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 20, 2020
@mlline00
Copy link
Contributor Author

Both Windows test suites hit AppVeyor's 60 minute build limit. I have seen this happen several times; particularly during US business hours. Not sure what, if anything, can be done about it. Quite certain checks will pass if rerun in ~12 hours.

Has anyone looked into moving the Windows tests to another platform? Is this something that makes sense for the project? CircleCI added Windows support ~6 months ago. Azure Pipelines is another viable option. If there's interest, it is something I can work on.

@mlline00
Copy link
Contributor Author

This time codecov upload failed. I haven't observed this before:

NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x039D1F10>: Failed to establish a new connection: [Errno 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond'

Will kick off the CI tests again.

kalefranz
kalefranz approved these changes Apr 2 8000 6, 2020
View reviewed changes
Copy link
Contributor
@kalefranz kalefranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're going to figure out how to speed up our tests, or move away from appveyor. Good to have py27 enabled again though. Thanks so much for the help!

One note in the future... At some point we'll go back and put the conda-canary channel back as highest priority. I'm not sure how consistent we've been with it for conda and conda's dependency releases though, so I don't mind dropping it for now until I can verify our processes there.

@kalefranz kalefranz merged commit 88670f3 into conda:master Apr 26, 2020
@kalefranz kalefranz added this to the 4.8.4 milestone Apr 26, 2020
@mlline00 mlline00 deleted the py27_win_ci branch June 15, 2020 21:28
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalefranz kalefranz kalefranz approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
4.8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mlline00 @kalefranz
0