8000 print help on incomplete command by cjmartian · Pull Request #9660 · conda/conda · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

print help on incomplete command #9660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Conversation

cjmartian
Copy link
Contributor
@cjmartian cjmartian commented Feb 4, 2020

This is associated with #9625

Currently running conda env config raises an AttributeError because our config_parser doesn't have a default function.

I think the intended use of conda env config is to give another positional argument that allows you to list, set, and unset env vars.

I added a default function that prints the help text when conda env config is called.

Fixes #9625

@cjmartian cjmartian requested a review from a team as a code owner February 4, 2020 19:20
@cla-bot cla-bot bot added the cla-signed [bot] added once the contributor has signed the CLA label Feb 4, 2020
@angloyna
Copy link
Contributor

@cjmartian i think pulling in conda master might fix the tests and we can merge this

Copy link
Contributor
@angloyna angloyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and it looks much nicer than the error report.

@angloyna angloyna merged commit d2914ae into conda:master Jul 31, 2020
@cjmartian cjmartian deleted the fix-env-config branch July 31, 2020 20:29
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conda env config (or other inappropriate/incomplete commands) results in AttributeError(possibly related to argparse ?)
2 participants
0