Use PEP440 compatible version for canary builds #14860
Conversation
Co-Authored-By: Jonathan J. Helmus <jjhelmus@gmail.com>
Co-Authored-By: Jonathan J. Helmus <jjhelmus@gmail.com>
Review build status
Once it's done, use this command to try it out in a new conda environment:
|
CodSpeed Performance ReportMerging #14860 will not alter performanceComparing Summary
|
setuptools-scm=8.2.1|
https://packaging.python.org/en/latest/specifications/version-specifiers/#dvcs-based-version-labels has suggestions on how to produce compatible version from version control systems. Of note is:
This is in line with the approach here, |
f55fc12 to
11ef3b7
Compare
|
Blocked by windows test failure, can be fixed by either of the following: |
Description
Closes #14859, #14843, #14858
Do not use yanked version of
setuptools-scmdue to issues with version handling.See #14858 (comment)
After much investigations and tinkering we have determined the issue is not with
setuptools-scm 8.2.1but rather with the version generated in our recipe.The
setuptools-scm 8.2.1package added an activation script settingexport SETUPTOOLS_SCM_PRETEND_VERSION=${PKG_VERSION}resulting inhatchlingautomatically detecting the recipe version.Since
{{ GIT_BUILD_STR }}=={{ GIT_DESCRIBE_NUMBER }}_{{ GIT_DESCRIBE_HASH }}we were creating an invalid version which hatchling rejected.The solution is to use
{{ GIT_DESCRIBE_NUMBER }}+{{ GIT_DESCRIBE_HASH }}instead of{{ GIT_BUILD_STR }}.Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?