Improve conda config support for nested keys
#10572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug: $ echo "conda_build:">>~/.condarc $ echo " cache_dir: /opt/conda/conda-bld">>~/.condarc $ conda config --get conda_build.cache_dir unknown key conda_build.cache_dir The diagnosis: We use nested keys in conda-build, but conda refuses to play ball because it cares not for our nesting when it looks for the key. The fix: Step through the requested, dotted, nested key and rc_config in lock-step. The resolution: $ conda config --get conda_build.cache_dir --set conda_build.cache_dir /opt/conda/conda-bld
Separate tests into more manageable chunks; reduce use of magic strings
Needed to check/improve PR#10447
…-keys Testing & improving PR#10447
Failures involved either invalid keys slipping through or incorrect `--add` or `--set` commands being generated for nested keys.
The comment may be removed from the output config, depending on the installed versions of Python & other dependencies, so check for the absence of the key instead.
katietz
approved these changes
Mar 26, 2021
|
Thanks @chenghlee! I have a conda-build PR to fix lots of CDT bugs that I hope to get merged once this makes it into a release. Any idea when that might be? |
|
@mingwandroid: Hoping to tag the 4.10.0 release by today, Monday at the latest. |
cjmartian
approved these changes
Mar 26, 2021
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially an extension of PR #10447 to address certain test failures induced by that PR.