Optimize SSE build event streaming #9169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Replace fmt.Sscanf with strconv.ParseUint for more efficient header parsing
- Replace fmt.Sprintf("%d", id) with strconv.FormatUint for more efficient string conversion
- Use Header().Set() to prevent duplicate headers
- Add validation for http.Flusher type assertion
- Improve error handling and logging context
- Enhance code readability with consistent structure and formatting
- Refactor event writing for better maintainability
- Replace fmt.Sscanf with strconv.ParseUint for more efficient header parsing
- Replace fmt.Sprintf("%d", id) with strconv.FormatUint for more efficient string conversion
- Use Header().Set() to prevent duplicate headers
- Add validation for http.Flusher type assertion
- Improve error handling and logging context
- Enhance code readability with consistent structure and formatting
- Refactor event writing for better maintainability
Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
| w.WriteHeader(http.StatusBadRequest) | ||
| return | ||
| } | ||
|
|
||
| eventID++ | ||
| eventID = uint(parsedID) + 1 |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
There was a problem hiding this comment.
we're well past 32 bit these days smh
|
In combo with vito/go-sse#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.