Add missing GCC 15 key to settings.yml
#18193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
memsharded
approved these changes
Apr 29, 2025
| @@ -461,14 +461,11 @@ def detect_gcc_compiler(compiler_exe="gcc"): | |||
| if "clang" in out: | |||
| return None, None, None | |||
|
|
|||
| ret, out = detect_runner('%s -dumpversion' % compiler_exe) | |||
| ret, out = detect_runner('%s -dumpfullversion -dumpversion' % compiler_exe) | |||
There was a problem hiding this comment.
Is it possible that some non mainstream gcc-like compilers do not support -dumpfullversion and crash?
I think we previously didn't add this because of the potential risk of breaking others, but we can try
|
won't conan/conan/internal/api/detect/detect_api.py Line 585 in dc0a754 This behaviour seems to be intentional, see also conan/conan/internal/api/detect/detect_api.py Lines 568 to 569 in 705672e |
|
Yes, the profile default gcc version 15 is expected, good catch |
settings.yml
czoido
approved these changes
Apr 29, 2025
c5e5feb to
315d1b4
Compare
|
Works on my machine, thanks for the reactivity ! |
Sign up for free
to join this conversation on GitHub
6A7B
.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add missing GCC 15 key to
settings.ymlDocs: conan-io/docs#4084
This PR adds a missing
15version for gcc, which is what the profiles detect by default.In 2.17 we'll add
-dumpfullversionto thedetect_gcc_compiler()detect method