10000 organizing cli, moving to api by memsharded · Pull Request #17961 · conan-io/conan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

organizing cli, moving to api #17961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

memsharded
Copy link
Member
@memsharded memsharded commented Mar 14, 2025

Changelog: Fix: Make some from conan.internal and from conans usages from CLI commands private, moving to ConanAPI.
Docs: Omit

@memsharded memsharded marked this pull request as ready for review March 14, 2025 09:01
@memsharded memsharded added this to the 2.15.0 milestone Mar 14, 2025
@czoido czoido merged commit f31a78f into conan-io:develop2 Mar 14, 2025
15 checks passed
@memsharded memsharded deleted the refactor/cli_privates branch March 14, 2025 10:09
perseoGI added a commit to perseoGI/conan that referenced this pull request Mar 28, 2025
memsharded added a commit that referenced this pull request Mar 28, 2025
Changelog: omit
Docs: omit


This PR fixes two issues related with conan runners:

1. An error introduced in #17961 where an invalid runner instance were
being returned instead of a runner class

2. Make runner tests run again in GitHub actions. This PR
#17839 forced the github job to
use a custom docker image instead which does not have enabled docker in
docker feature, making pytest to skip all the conan runner tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0