8000 add warning-risk for deprecated packages by memsharded · Pull Request #17957 · conan-io/conan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add warning-risk for deprecated packages #17957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

add warning-risk for deprecated packages #17957

merged 1 commit into from
Mar 13, 2025

Conversation

memsharded
Copy link
Member
@memsharded memsharded commented Mar 13, 2025 •
edited
Loading

Changelog: Fix: Add warning for deprecated attribute in recipes.
Docs: conan-io/docs#4041

Close #17952

@memsharded memsharded added this to the 2.15.0 milestone Mar 13, 2025
@memsharded memsharded requested a review from uilianries March 13, 2025 10:36
@memsharded memsharded mentioned this pull request Mar 13, 2025
Closed
@uilianries
Copy link
Member

I would include the case deprecated = "foobar", where the warning message suggests to use foobar as replacement for the 8000 deprecated reference.

@memsharded
Copy link
Member Author

I would include the case deprecated = "foobar", where the warning message suggests to use foobar as replacement for the deprecated reference.

@uilianries The deprecation is already showing the reason:

    if deprecated:
        output.info("Deprecated", Color.BRIGHT_YELLOW)
        for d, reason in deprecated.items():
            reason = f": {reason}" if reason else ""
            output.info("    {}{}".format(d, reason), Color.BRIGHT_CYAN)

uilianries
uilianries approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member
@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for backporting it!

@memsharded memsharded merged commit 2c1fddd into conan-io:develop2 Mar 13, 2025
15 checks passed
@memsharded memsharded deleted the fix/add_deprecated_warning branch March 13, 2025 11:37
@memsharded memsharded mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

[bug] Deprecated attribute does not raise a warning when enabled
3 participants
@memsharded @uilianries @AbrilRBS
0