8000 Use correct attribute type instead of package_type by NokiDev · Pull Request #17943 · conan-io/conan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use correct attribute type instead of package_type #17943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 13, 2025
Merged

Use correct attribute type instead of package_type #17943

merged 6 commits into from
Mar 13, 2025

Conversation

NokiDev
Copy link
Contributor
@NokiDev NokiDev commented Mar 11, 2025 •
edited by czoido
Loading

Changelog: Fix: _Component() has no package_type property.
Docs: Omit

Closes: #17942

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@CLAassistant
Copy link
CLAassistant commented Mar 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@memsharded
Copy link
Member

Hi @NokiDev

Thanks for your contribution. Lets start with the test that reproduces the issue first, as I have commented in #17942 (comment)

@NokiDev NokiDev changed the title Use correct property type instead of package_type Use correct attribute type instead of package_type Mar 12, 2025
@NokiDev NokiDev force-pushed the fix-wrong-property-usage-in-cmakedeps2 branch from fef0648 to 7777a0e Compare March 12, 2025 10:51
@NokiDev NokiDev force-pushed the fix-wrong-property-usage-in-cmakedeps2 branch from 7460a4b to 0a1c1ea Compare March 12, 2025 13:36
@NokiDev NokiDev mentioned this pull request Mar 12, 2025
Closed
@memsharded memsharded merged commit 8483357 into conan-io:develop2 Mar 13, 2025
15 checks passed
@memsharded memsharded added this to the 2.15.0 milestone Mar 13, 2025
This was referenced Mar 13, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

[bug] - CMakeConfigDeps components depending on components from same package raise an error
3 participants
@NokiDev @CLAassistant @memsharded
0