8000 Protect access to CppInfo private property required_components by perseoGI · Pull Request #17692 · conan-io/conan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Protect access to CppInfo private property required_components #17692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

Protect access to CppInfo private property required_components #17692

merged 2 commits into from
Feb 4, 2025

Conversation

perseoGI
Copy link
Contributor
@perseoGI perseoGI commented Feb 4, 2025 •
edited by memsharded
Loading

Changelog: Fix: Protect erroneous assignment of cpp_info/components.required_components = xxx, for required_components property. Now it will raise a proper error.
Docs: omit

Regarding the issue of CCI, one recipe was overriding the internal property required_components. This should have triggered an exception beforehand.

conan-io/conan-center-index#26455

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@memsharded memsharded added this to the 2.13.0 milestone Feb 4, 2025
@memsharded memsharded self-assigned this Feb 4, 2025
@perseoGI perseoGI force-pushed the pgi/fix/cpp_info/required_components branch from 5376f2d to f8db23b Compare February 4, 2025 13:18
@memsharded memsharded merged commit 1a350e3 into conan-io:develop2 Feb 4, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@perseoGI @AbrilRBS @memsharded
0