10000 first pass on removing git integration and git sync by martintc · Pull Request #439 · comtrya/comtrya · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

first pass on removing git integration and git sync #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 23, 2024
Merged

first pass on removing git integration and git sync #439

merged 3 commits into from
Aug 23, 2024

Conversation

martintc
Copy link
Member
@martintc martintc commented Aug 22, 2024 •
edited
Loading

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Git integration via git-sync and git2-rs which pulls in a transitive dependency on openssl. Since this causes a lot of problems, just get rid of it.

What is the expected behavior?

git action will no longer be available.

What is the motivation / use case for changing the behavior?

see the following issues:
#409
#438
#260
#227
#249
#143

Please tell us about your environment:

Version (comtrya --version): 0.8.8
Operating system: macOS 14.5

@martintc martintc requested review from rawkode and icepuma August 22, 2024 03:28
@codecov-commenter
Copy link
codecov-commenter commented Aug 22, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.09%. Comparing base (b574682) to head (c53899d).
Report is 28 commits behind head on main.

Files Patch % Lines
lib/src/manifests/providers/mod.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   28.59%   27.09%   -1.51%     
==========================================
  Files          85       83       -2     
  Lines        2301     2244      -57     
==========================================
- Hits          658      608      -50     
+ Misses       1643     1636       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

icepuma
icepuma reviewed Aug 23, 2024
View reviewed changes
Copy link
Member
@icepuma icepuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are leftovers in the docs about the git stuff, like actions / remote manifests / etc.

@martintc martintc merged commit 83ad0cf into comtrya:main Aug 23, 2024
4 checks passed
@thebino
Copy link
thebino commented Sep 3, 2024

@martintc I updated the documentation regarding this change: comtrya/comtrya.dev#10

@martintc martintc mentioned this pull request Nov 18, 2024
Closed
@martintc martintc mentioned this pull request Dec 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icepuma icepuma icepuma approved these changes

@rawkode rawkode Awaiting requested review from rawkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martintc @codecov-commenter @thebino @icepuma
0