8000 Feat/snap provider by davenport1 · Pull Request #488 · comtrya/comtrya · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat/snap provider #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 17, 2024
Merged

Feat/snap provider #488

merged 7 commits into from
Oct 17, 2024

Conversation

davenport1
Copy link
Contributor
@davenport1 davenport1 commented Oct 17, 2024 •
edited
Loading

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Snap was not implemented as a provider

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

N/A

What is the expected behavior?

Snap supported as a provider

What is the motivation / use case for changing the behavior?

Feature request - Issue #64

Please tell us about your environment:

Version (comtrya --version): 0.9.0
Operating system: macOS

martintc
martintc reviewed Oct 17, 2024
View reviewed changes
@martintc
Copy link
Member

Also want to mention, this is in connection with issue #64

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 34.21053% with 25 lines in your changes missing coverage. Please review.

Project coverage is 26.99%. Comparing base (b574682) to head (2a5f748).
Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/actions/package/providers/snapcraft.rs 35.13% 24 Missing ⚠️
lib/src/actions/package/providers/mod.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   28.59%   26.99%   -1.61%     
==========================================
  Files          85       86       +1     
  Lines        2301     2434     +133     
==========================================
- Hits          658      657       -1     
- Misses       1643     1777     +134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintc martintc merged commit ecf0235 into comtrya:main Oct 17, 2024
6 checks passed
@chenrui333 chenrui333 mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martintc martintc martintc approved these changes

4C50
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davenport1 @martintc @codecov-commenter
0