8000 correct install option by martintc · Pull Request #441 · comtrya/comtrya · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

correct install option #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024
Merged

correct install option #441

merged 1 commit into from
Aug 23, 2024

Conversation

martintc
Copy link
Member

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

bsdpkg provider fails to install.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

Run the following manifest snippet on a FreeBSD system

actions:
  - action: package.install
    list:
    - sd
    - just

What is the expected behavior?

Should install successfully

What is the motivation / use case for changing the behavior?

Refer to issue #433

We pass in the -n option when it should be -y so that way comtrya can automatically pass in the yes option when prompted with the 'are you sure' prompt from the package manager.

Please tell us about your environment:

Version (comtrya --version): 0.8.8
Operating system: FreeBSD 14.1

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.36%. Comparing base (b574682) to head (13fe16f).
Report is 25 commits behind head on main.

Files Patch % Lines
lib/src/actions/package/providers/bsdpkg.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   28.59%   28.36%   -0.24%     
==========================================
  Files          85       86       +1     
  Lines        2301     2313      +12     
==========================================
- Hits          658      656       -2     
- Misses       1643     1657      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintc martintc merged commit cc83f49 into comtrya:main Aug 23, 2024
4 checks passed
@martintc martintc deleted the fix-bsdpkg branch August 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0