8000 Add users to group and add groups by martintc · Pull Request #307 · comtrya/comtrya · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add users to group and add groups #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Conversation

martintc
Copy link
Member

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Group management is unimplemented

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

Ability to add groups and users to groups on MacOS systems.

What is the motivation / use case for changing the behavior?

Feature parity with other operating systems.

Please tell us about your environment:

Version (comtrya --version): 0.8.3
Operating system: MacOs 13.1

@codecov-commenter
Copy link

Codecov Report

Base: 45.48% // Head: 44.63% // Decreases project coverage by -0.84% ⚠️

Coverage data is based on head (0b8c8f6) compared to base (5537b4a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   45.48%   44.63%   -0.85%     
==========================================
  Files          81       82       +1     
  Lines        2836     2890      +54     
==========================================
  Hits         1290     1290              
- Misses       1546     1600      +54     
Impacted Files Coverage Δ
lib/src/actions/group/providers/macos.rs 0.00% <0.00%> (ø)
lib/src/actions/group/providers/mod.rs 25.00% <0.00%> (-3.58%) ⬇️
lib/src/actions/user/providers/macos.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@martintc martintc merged commit 951285b into comtrya:main Jan 14, 2023
@martintc martintc deleted the macos_groups branch December 29, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0