New release action #380
New release action #380
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage 28.26% 28.26%
=======================================
Files 85 85
Lines 2289 2289
=======================================
Hits 647 647
Misses 1642 1642 ☔ View full report in Codecov by Sentry. |
.github/workflows/main.yaml
Outdated
| name: comtrya-aarch64-unknown-linux-gnu | ||
| cross: false | ||
| cargo_command: ./cross | ||
| skip_tests: true |
There was a problem hiding this comment.
What's the problem with the tests here?
There was a problem hiding this comment.
It may work now. I initially set them to false as I worked through the openssl dependencies and to get faster feedback on if the rest of the pipeline worked. There is a chance that I might have run into an issue with tests failing with some weird results. But we can test this out. But I remember running the aarch64 test on my linux amd64 box and getting weird errors from the tests. But when I tired up an actual aarch64 Linux machine on hardware, the tests were fine? But that was also a month ago.
There was a problem hiding this comment.
Oh and looking at the original main.yaml, the only time we run tests is during the lint action, we don't actually run tests against the compiled output for each architecture
But Ill push a commit setting skip_tests to false in case we ever want to actually turn that on.
.github/workflows/main.yaml
Outdated
| name: comtrya-aarch64-apple-darwin | ||
| cross: true | ||
| cargo_command: ./cross | ||
| skip_tests: true |
There was a problem hiding this comment.
What's the problem with the tests here?
There was a problem hiding this comment.
It may work now. I initially set them to false as I worked through the openssl dependencies and to get faster feedback on if the rest of the pipeline worked. There is a chance that I might have run into an issue with tests failing with some weird results. But we can test this out. But I remember running the aarch64 test on my linux amd64 box and getting weird errors from the tests. But when I tired up an actual aarch64 Linux machine on hardware, the tests were fine? But that was also a month ago.
There was a problem hiding this comment.
Oh and looking at the original main.yaml, the only time we run tests is during the lint action, we don't actually run tests against the compiled output for each architecture
But Ill push a commit setting skip_tests to false in case we ever want to actually turn that on.
I'm submitting a
What is the current behaviour?
Linux aarch64 artifact output is incorrect as noted in issue #337
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
What is the expected behavior?
What is the motivation / use case for changing the behavior?
Binary release artifacts for linux aarch64 triplet were not correct. There were issues with using cross in the current action used to build. This introduces a new action to cross build rust projects pretty easily.
Please tell us about your environment:
Version (
comtrya --version):Operating system: