-
Notifications
You must be signed in to change notification settings - Fork 53
fix: attempt to fix aarch64 linux binaries #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage 28.59% 28.59%
=======================================
Files 84 84
Lines 2263 2263
=======================================
Hits 647 647
Misses 1616 1616 ☔ View full report in Codecov by Sentry. |
martintc
added a commit
to martintc/comtrya
that referenced
this pull request
Nov 8, 2023
This reverts commit 2fa4278.
martintc
added a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a
What is the current behaviour?
Binaries for aarch64-unknown-linux-gnu are not compiled correctly in the artifacts.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
What is the expected behavior?
aarch64-unknown-linux-gnu binary is an actual aarch64 binary
What is the motivation / use case for changing the behavior?
Please tell us about your environment:
Version (
comtrya --version
):Operating system: