8000 Initial implementation for supporting toml files by martintc · Pull Request #297 · comtrya/comtrya · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Initial implementation for supporting toml files #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 6, 2023
Merged

Initial implementation for supporting toml files #297

merged 7 commits into from
Jan 6, 2023

Conversation

martintc
Copy link
Member
@martintc martintc commented Jan 1, 2023

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Comtrya only support manifest files written in yaml.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

Comtrya will be able to support manifests written in toml

What is the motivation / use case for changing the behavior?

Request in #285

Please tell us about your environment:

Version (comtrya --version): 0.8.2
Operating system: Fedora 37

@codecov-commenter
Copy link

Codecov Report

Base: 46.27% // Head: 46.12% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (f1c47e7) compared to base (b3e26c1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   46.27%   46.12%   -0.16%     
==========================================
  Files          79       79              
  Lines        2766     2775       +9     
==========================================
  Hits         1280     1280              
- Misses       1486     1495       +9
Impacted Files Coverage Δ
lib/src/manifests/load.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rawkode
Copy link
Member
rawkode commented Jan 4, 2023

@martintc Need any help with this, or just time?

@rawkode
Copy link
Member
rawkode commented Jan 5, 2023

@martintc Is this ready to go? :)

@martintc martintc marked this pull request as ready for review January 6, 2023 00:13
@martintc martintc requested review from icepuma and rawkode January 6, 2023 00:26
@rawkode
Copy link
Member
rawkode commented Jan 6, 2023

@martintc Please avoid merging main into branches, as it means we can't rebase branches into main.

Instead, git rebase -i origin main when you need the freshest changes in your branch :)

@rawkode rawkode merged commit 4328e82 into comtrya:main Jan 6, 2023
@martintc martintc deleted the toml branch December 29, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icepuma icepuma icepuma approved these changes

@rawkode rawkode Awaiting requested review from rawkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martintc @codecov-commenter @rawkode @icepuma
0