Proposal to enable cWETHv3 market on Goerli #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincheng96
commented
Jan 4, 2023
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| "tracking": { | |||
| "indexScale": "1e15", | |||
| "baseSupplySpeed": "0e15", | |||
| "baseSupplySpeed": "447916666666e0", | |||
There was a problem hiding this comment.
I could modify the stringToBigInt function to accept non-scientific notation numbers as well. But this is a quick workaround.
df1eb4b to
887a1cd
Compare
3580ac3 to
7ae47b2
Compare
7ae47b2 to
8773058
Compare
kevincheng96
added a commit
that referenced
this pull request
Jan 5, 2023
kevincheng96
added a commit
that referenced
this pull request
Jan 17, 2023
jflatow
pushed a commit
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact run: https://github.com/compound-finance/comet/actions/runs/3849939037/jobs/6559516200
Proposal executed: https://goerli.etherscan.io/tx/0xc7e1755a28378570de1c07b69736ec57e4da69da22f0a9e8cf692fddb551c043