8000 [WIP] #329 warn on replace by cordoval · Pull Request #334 · composer/packagist · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[WIP] #329 warn on replace #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[WIP] #329 warn on replace #334

wants to merge 3 commits into from

Conversation

cordoval
Copy link

👶 don't judge before this turns into RFC
#329

@cordoval
Copy link
Author

@simensen am i missing anything?

i got a bit stuck on the js here https://github.com/composer/packagist/pull/334/files#L3R46 i want to disable/enable the submit on checking the checkbox and also avoid duplication of the appended warning div when clicking on check twice

@cordoval
Copy link
Author 
if($('.accept-warning').checked()) {
    submitButton.attr('disabled', 'disabled').addClass('disabled');
} else {
    submitButton.removeAttr('disabled').removeClass('disabled');
}

/cc @dragoonis

thanks

@staabm
Copy link
staabm commented Nov 26, 2013

just put those lines into 2 functions, like

function disableSubmit() {
  submitButton.attr('disabled', 'disabled').addClass('disabled');
}

and -reuse them.

AFAIK there is no .checked() in jquery, you need to use .is(":checked")

@cordoval
Copy link
Author

closing as per @naderman last comment and the controversy on the blogs 👶

@cordoval cordoval closed this Feb 21, 2014
@cordoval cordoval deleted the feature/329-warnOnReplace branch February 21, 2014 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cordoval @staabm
0