8000 Allow providers which are selected to be installed in place of existing packages which do not satisfy requirements by Seldaek · Pull Request #8561 · composer/composer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow providers which are selected to be installed in place of existing packages which do not satisfy requirements #8561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

Allow providers which are selected to be installed in place of existing packages which do not satisfy requirements #8561

merged 1 commit into from
Jan 30, 2020

Conversation

Seldaek
Copy link
Member
@Seldaek Seldaek commented Jan 30, 2020

Fixes #6753

I think it's fine really as per the 3 new tests, as they only get installed if selected, this isn't risky.

@Seldaek Seldaek added this to the 2.0-core milestone Jan 30, 2020
@Seldaek Seldaek requested a review from naderman January 30, 2020 12:36
@Seldaek Seldaek force-pushed the allow-providers-even-on-match branch from 7b582d8 to e520b54 Compare January 30, 2020 12:59
naderman
naderman requested changes Jan 30, 2020
View reviewed changes
Copy link
Member
@naderman naderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for @stof 's comment and the few json comments

@Seldaek Seldaek force-pushed the allow-providers-even-on-match branch from e520b54 to 2f6a499 Compare January 30, 2020 13:02
@Seldaek
Allow providers which are selected to be installed in place of existi…
8a41f1a 
…ng packages which do not satisfy requirements, fixes composer#6753
@Seldaek Seldaek force-pushed the allow-providers-even-on-match branch from 2f6a499 to 8a41f1a Compare January 30, 2020 13:10
@Seldaek Seldaek merged commit f611c64 into composer:2.0 Jan 30, 2020
@Seldaek Seldaek deleted the allow-providers-even-on-match branch January 30, 2020 13:22
@naderman naderman self-requested a review January 30, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@naderman naderman Awaiting requested review from naderman

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
2.0-core
Development

Successfully merging this pull request may close these issues.
3 participants
@Seldaek @naderman @stof
0