Comment GC disable and enable GC after run #3503
Conversation
| @@ -336,6 +337,8 @@ public function run() | |||
| } | |||
| } | |||
|
|
|||
| gc_enable(); | |||
There was a problem hiding this comment.
this triggers a warning on HHVM for some configurations, so this should be handled
There was a problem hiding this comment.
which kind of warning ? is it something that can be handled by wrapping it in a "if not hhvm" ?
There was a problem hiding this comment.
ok, i've quickly check and it can be done with
if (defined('HHVM_VERSION')) {
// Code
}
(dunno if it helps)
|
|
| @@ -160,6 +160,7 @@ public function __construct(IOInterface $io, Config $config, RootPackageInterfac | |||
| */ | |||
| public function run() | |||
| { | |||
| // Disable garbage collection to save memory and time | |||
There was a problem hiding this comment.
it is not saving memory. It is about saving time because the GC will be triggered many times (because of the amount of Zval used in the solver for the package graph) for cases where it cannot collect anything (the refcount will take care of all the package graph objects btw)
Fixes #3488