Whitelist packages with names matching those specified before generating rules #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing rules Addresses composer#2690 doesn't do any performance optimisations yet which we could do now
| @@ -46,7 +46,7 @@ public function remove($packageName, LinkConstraintInterface $constraint = null) | |||
| protected function addJob($packageName, $cmd, LinkConstraintInterface $constraint = null) | |||
| { | |||
| $packageName = strtolower($packageName); | |||
| $packages = $this->pool->whatProvides($packageName, $constraint); | |||
| $packages = $this->pool->whatProvides($packageName, $constraint, true); | |||
There was a problem hiding this comment.
This may have to be a false, but it should be evaluated after the whitelist is generated I think. As it is, if you request the installation of symfony/process, it wouldn't be resolvable by installing symfony/symfony anymore - do we not have a test for that case?
|
Working on another test, this doesn't seem to work quite right yet. |
|
Added tests for the changes in this PR and it seems to be working now. |
naderman
added a commit
that referenced
this pull request
Feb 21, 2014
Whitelist packages with names matching those specified before generating rules
| { | ||
| if (isset($this->providerCache[$name][(string) $constraint])) { | ||
| return $this->providerCache[$name][(string) $constraint]; | ||
| $key = ((string) (int) $mustMatchName).((string) $constraint); |
There was a problem hiding this comment.
no need to cast to string explicitly. the concatenation operator already does it
filbertkm
pushed a commit
to wmde/WikidataBuilder
that referenced
this pull request
Feb 24, 2014
includes security fix composer/composer#2733
filbertkm
pushed a commit
to wmde/puppet-composer
that referenced
this pull request
Feb 24, 2014
includes security fix composer/composer#2733
This was referenced Feb 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2690 but doesn't do any performance optimizations yet which we
could do now