8000 Adds algorithm create redirect view by jmsmkn · Pull Request #3841 · comic/grand-challenge.org · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adds algorithm create redirect view #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We†8000 ™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Conversation

jmsmkn
Copy link
Member
@jmsmkn jmsmkn commented Feb 19, 2025

Users are presented with the phases that they have the "create_phase_submission" which is currently public phases for the participants group, or all phases for the admins group.

Screenshot 2025-02-19 at 17 11 18

The check on whether the phase is open is very complex and in a mixin that cannot really be re-used here, so we just clean the phase to see if it is open for non-admins. The full check is then done on the redirect but the errors are not as nice.

Screenshot 2025-02-19 at 17 11 25

If the phase is open then the user will end up on the usual page.

Screenshot 2025-02-19 at 17 11 33

Those with custom algorithm permissions will see the extra link.

Screenshot 2025-02-19 at 17 15 39

Closes #3671

@jmsmkn jmsmkn marked this pull request as ready for review February 19, 2025 16:16
@jmsmkn jmsmkn requested a review from amickan as a code owner February 19, 2025 16:16
amickan
amickan previously approved these changes Feb 20, 2025
Copy link
Contributor
@amickan amickan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amickan amickan removed their assignment Feb 20, 2025
Co-authored-by: Anne Mickan <amickan1990@gmail.com>
@jmsmkn jmsmkn merged commit 55c1b74 into main Feb 20, 2025
8 checks passed
@jmsmkn jmsmkn deleted the 3671_create_algorithm_button branch February 20, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
41B4
Development

Successfully merging this pull request may close these issues.

Create algorithm from challenge form visibility
2 participants
0