8000 Onboarding Tasks Creation by chrisvanrun · Pull Request #3834 · comic/grand-challenge.org · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Onboarding Tasks Creation #3834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 18, 2025
Merged

Onboarding Tasks Creation #3834

merged 11 commits into from
Feb 18, 2025

Conversation

chrisvanrun
Copy link
Contributor

Part of the pitch:

This PR adds the actual task creation when a challenge gets created.

Showcase

image

@chrisvanrun chrisvanrun requested a review from amickan as a code owner February 17, 2025 09:33
@chrisvanrun chrisvanrun requested a review from jmsmkn as a code owner February 17, 2025 13:05
jmsmkn
jmsmkn requested changes Feb 17, 2025
View reviewed changes
Copy link
Member
@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but would prefer that signals are not used. I have not reviewed the content of the tasks, that is for @miriam-groeneveld

chrisvanrun
chrisvanrun commented Feb 17, 2025
View reviewed changes
chrisvanrun
chrisvanrun commented Feb 17, 2025
View reviewed changes
jmsmkn
jmsmkn previously approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member
@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of questions about the tasks that Miriam should also look at but this is fine for me.

miriam-groeneveld
miriam-groeneveld reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor
@miriam-groeneveld miriam-groeneveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, indeed might be revisited a few times.

@chrisvanrun
Copy link
Contributor Author < 8000 /div>
chrisvanrun commented Feb 17, 2025 •
edited
Loading

Thanks everyone. I'll revise the questions tasks tomorrow and will ask Miriam for the final approval.

@chrisvanrun
Copy link
Contributor Author

New tasks:

image

jmsmkn
jmsmkn previously approved these changes Feb 18, 2025
View reviewed changes
@jmsmkn jmsmkn dismissed their stale review February 18, 2025 11:59

Tests need to be updated, perhaps they are too sensitive?

miriam-groeneveld
miriam-groeneveld reviewed Feb 18, 2025
View reviewed changes
@chrisvanrun
Copy link
Contributor Author
chrisvanrun commented Feb 18, 2025 •
edited
Loading

Tests need to be updated, perhaps they are too sensitive?

Not sure. It's a bit of a hassle now but I would def like to know in the future if any onboarding task went missing or got muddled. I've just limited to the titles now but forgot to update them pre-lunch. Alternative is checking the number of tasks only but that might bite us in the future.

@jmsmkn jmsmkn merged commit ba13b08 into main Feb 18, 2025
8 checks passed
@jmsmkn jmsmkn deleted the onboarding-tasks-on-challenges branch February 18, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miriam-groeneveld miriam-groeneveld miriam-groeneveld approved these changes

@jmsmkn jmsmkn jmsmkn left review comments

@amickan amickan Awaiting requested review from amickan amickan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisvanrun @jmsmkn @amickan @miriam-groeneveld
0