8000 Onboarding tasks emails by chrisvanrun · Pull Request #3822 · comic/grand-challenge.org · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Onboarding tasks emails #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 17, 2025
Merged

Onboarding tasks emails #3822

merged 16 commits into from
Feb 17, 2025

Conversation

chrisvanrun
Copy link
Contributor
@chrisvanrun chrisvanrun commented Feb 7, 2025 •
edited
Loading

Part of the pitch:

This PR adds the email reminders for onboarding tasks.

Showcase

Challenge Organizers

Reminder: gentle

Subject: [testserver] [test-challenge-0] Reminder: 1 Onboarding Task Soon Due

Dear test_user_0000,

Your challenge test-challenge-0 has 1 onboarding task that is are soon due. To view and complete onboarding tasks, go here.

Regards,
The Testserver:8000 Team

Alert: call for action

Subject: [testserver] [test-challenge-0] Action Required: 1 Onboarding Task Overdue

Dear test_user_0000,

Your challenge test-challenge-0 has 1 onboarding task that is overdue. To view and complete onboarding tasks go here.

Regards,
The Testserver:8000 Team

Support

Note: challenge organizers are late

Subject: [Django] [test-challenge-0] 1 Organizer Onboarding Task Overdue
The organizers of challenge test-challenge-0 have 1 onboarding task that is overdue: the organizers have been alerted.

Alert: support is late

Subject: [Django] [test-challenge-0] Action required: 1 Support Onboarding Task Overdue
For the challenge test-challenge-0, the support staff are late on completing 1 onboarding task.

jmsmkn
jmsmkn requested changes Feb 10, 2025
View reviewed changes
Copy link
Member
@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a suggestion for optimisation

@chrisvanrun chrisvanrun requested a review from jmsmkn February 11, 2025 11:19
jmsmkn
jmsmkn reviewed Feb 11, 2025
View reviewed changes
jmsmkn
jmsmkn reviewed Feb 11, 2025
View reviewed changes
chrisvanrun and others added 2 commits February 11, 2025 13:39
@chrisvanrun @jmsmkn
Update app/grandchallenge/challenges/tasks.py
a3ab419 
Co-authored-by: James Meakin <12661555+jmsmkn@users.noreply.github.com>
@chrisvanrun
Add a retry on no lock
4c75e59
@chrisvanrun chrisvanrun requested a review from jmsmkn February 11, 2025 13:05
jmsmkn
jmsmkn reviewed Feb 11, 2025
View reviewed changes
miriam-groeneveld
miriam-groeneveld reviewed Feb 11, 2025
View reviewed changes
@chrisvanrun
Copy link
Contributor Author

New email format:

Challenge orgs

Reminder: gentle

Subject: [testserver] [test-challenge-2] Reminder: 1 Onboarding Task Soon Due

Dear test_user_0007,

Your challenge test-challenge-2 has 1 onboarding task that is due sometime in the next week.

To view and complete onboarding tasks go here.

Feel free to ask us for any assistance.

Regards,
The Testserver:8000 Team

This is an automated service email from testserver.

Alert: action!

Subject: [testserver] [test-challenge-0] Action Required: 1 Onboarding Task Overdue

Dear test_user_0001,

Your challenge test-challenge-0 has 1 onboarding task that is overdue.

Please complete them as soon as possible: the due date was 2 weeks, 1 day ago.

To view and complete onboarding tasks go here.

Feel free to ask us for any assistance.

Regards,
The Testserver:8000 Team

This is an automated service email from testserver.

Support staff

Note: challenge orgs are overdue

Subject: [Django] [test-challenge-0] Organizer Onboarding Tasks Overdue: 1
The organizers of challenge test-challenge-0 have 1 onboarding task(s) overdue: the organizers have been alerted.

Action: support is late

Subject: [Django] [test-challenge-1] Action required: 1 Support Onboarding Task Overdue
For the challenge test-challenge-1, the support staff are late on completing 1 support onboarding task. Deadline was 15 days ago

@chrisvanrun chrisvanrun requested a review from jmsmkn February 12, 2025 14:53
@chrisvanrun chrisvanrun assigned jmsmkn and unassigned chrisvanrun Feb 12, 2025
jmsmkn
jmsmkn requested changes Feb 12, 2025
View reviewed changes
Copy link
Member
@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing new here for me to review, did you forget to push?

@jmsmkn jmsmkn removed their assignment Feb 12, 2025
@chrisvanrun
Copy link
Contributor Author

There is nothing new here for me to review, did you forget to push?

My apologies, was a bit of a sudden rush because of a sudden realization that Thursday was a bit of a 'dead' day.

@chrisvanrun chrisvanrun requested a review from jmsmkn February 13, 2025 08:30
jmsmkn
jmsmkn reviewed Feb 13, 2025
View reviewed changes
Copy link
Member
@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, like the named tuple for passing around all of the info. Couple of small questions.

@chrisvanrun chrisvanrun requested a review from jmsmkn February 14, 2025 16:00
@chrisvanrun chrisvanrun assigned jmsmkn and unassigned chrisvanrun Feb 14, 2025
jmsmkn
jmsmkn approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member
@jmsmkn jmsmkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisvanrun chrisvanrun merged commit bcaa9ed into main Feb 17, 2025
8 checks passed
@chrisvanrun chrisvanrun deleted the onboarding-tasks-emails branch February 17, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miriam-groeneveld miriam-groeneveld miriam-groeneveld left review comments

@jmsmkn jmsmkn jmsmkn approved these changes

@amickan amickan Awaiting requested review from amickan amickan is a code owner

Assignees

@jmsmkn jmsmkn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisvanrun @jmsmkn @miriam-groeneveld
0