8000 Adjustable gpu types for algorithms by koopmant · Pull Request #3714 · comic/grand-challenge.org · GitHub

More Web Proxy on the site http://driver.im/

Adjustable gpu types for algorithms #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send yo 8000 u account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jmsmkn merged 26 commits into main from adjustable-gpu-types-for-algorithms

Dec 2, 2024

Contributor

koopmant commented

•

Make the selectable gpu type and maximum memory setting for algorithms adjustable using Phase settings. relevant phases are filtered when updating or creating an algorithm, this is based on inputs and outputs match, participant match, the phase submissions kind must be algorithm, and the phase must be public.
The new Phase settings are also used to validate algorithm gpu and memory settings when it is submitted to the phase.

Related to https://github.com/DIAGNijmegen/rse-roadmap/issues/346

koopmant added 3 commits

November 21, 2024 16:59


          Add fields for algorithm job requirement options to Phase

0921a33


          Use new option settings AlgorithmForPhaseForm

8a471a0


          Filter phases in algorithm form to get selectable gpus and max memory

51c20b6

koopmant self-assigned this

koopmant added 4 commits

November 22, 2024 17:04


          Validate algorithm job requirements on submission

3777c19


          Get algorithm directly from field data

f380f39


          Cleanup

cac02a6


          Add tests

004b674

koopmant marked this pull request as ready for review

November 22, 2024 19:32

koopmant requested review from amickan and jmsmkn as code owners

November 22, 2024 19:32

koopmant added 2 commits

November 22, 2024 21:36


          Fix test

d65d59b

Settings used in this test were outside of default options and limits, which are now validated on submission.


          Merge branch 'main' into adjustable-gpu-types-for-algorithms

f8560de

jmsmkn reviewed

View reviewed changes

app/grandchallenge/evaluation/forms.py Outdated Show resolved Hide resolved

jmsmkn reviewed

View reviewed changes

app/grandchallenge/evaluation/forms.py Outdated Show resolved Hide resolved

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Outdated Show resolved Hide resolved

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Outdated Show resolved Hide resolved

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Outdated Show resolved Hide resolved

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Outdated Show resolved Hide resolved

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Show resolved Hide resolved

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Outdated Show resolved Hide resolved

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Outdated Show resolved Hide resolved

koopmant and others added 8 commits

November 26, 2024 16:04


          Update app/grandchallenge/algorithms/forms.py

e667712

Co-authored-by: James Meakin <12661555+jmsmkn@users.noreply.github.com>


          Maintain order in gpu type choices

00b6c31

Co-authored-by: James Meakin <12661555+jmsmkn@users.noreply.github.com>


          Fix formatting

df61b26


          Use name instead of long labels

c8fc96a


          Maintain order of gpu type choices

dc36483


          Convert getters to properties

7d3df2b


          Revert "Get algorithm directly from field data"

This reverts commit f380f39.


          Remove cached property since queryset is not evaluated

4ae9544

koopmant added 3 commits

November 26, 2024 17:24


          Avoid fetching all records for maximum

f59fdf8


          Fix tests

4baf96c


          Use array aggregation which is slightly faster

f90c137

koopmant requested a review from jmsmkn

November 27, 2024 15:35

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Outdated Show resolved Hide resolved

koopmant added 3 commits

November 27, 2024 17:55


          Use rawsql to perform unnesting outside of python

e8f64aa


          Revert "Use rawsql to perform unnesting outside of python"

35651d4

This reverts commit e8f64aa.


          Reduce database query to one

c267b11

jmsmkn reviewed

View reviewed changes

app/grandchallenge/algorithms/forms.py Outdated Show resolved Hide resolved

jmsmkn assigned amickan and unassigned koopmant

jmsmkn requested review from amickan and removed request for amickan

November 28, 2024 00:02

8000


          Cleanup set creation

4881e8e

amickan reviewed

View reviewed changes

app/tests/algorithms_tests/test_forms.py Outdated Show resolved Hide resolved

amickan assigned koopmant and unassigned amickan


          Include other filters in test

cbb8f8c

koopmant assigned amickan and unassigned koopmant

amickan removed their assignment


          Use multiple inputs and outputs to test distinct

9ed66bb

jmsmkn approved these changes

View reviewed changes

jmsmkn merged commit cfd5c67 into main

8 checks passed

jmsmkn deleted the adjustable-gpu-types-for-algorithms branch

December 2, 2024 13:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0