pubsub/kvindexer:support for big numbers - v2 (backport #797) #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Applied Michaels patch * Added corner case tests, failing curently * Support for big floats and ints added * Added new util file * Fixed linter error * added internal package * Revert "added internal package" This reverts commit ef7f2b4. * added internal/indexer * Moved utils to internal * Fixed linter * Updated docs * Applied @sergio-mena s PR comments * Fixed linter * Return with error in compare float * Changelog entries * Apply lasaroj's comments. Co-authored-by: Lasaro <lasaro@informal.systems> * applied some PR comments * updated docs Co-authored-by: Sergio Mena <sergio@informal.systems> * Added errors and logger * Fixed linter * Fixed sentence in comment * Removed changelog * Avoid converting to string when parsing int to float * Added unexpected types to error messages * Added comment on the 8atom regex in pubsub --------- Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit f667d3f)
lasarojc
reviewed
May 16, 2023
libs/pubsub/query/query.go
Outdated
| // TODO(creachadair): The existing implementation allows anything number shaped | ||
| // to be treated as a number. This preserves the parts of that behavior we had | ||
| // tests for, but we should probably get rid of that. | ||
| 8000 | // We use this regex to support queries of the from "8atom", "6.5stake", |
There was a problem hiding this comment.
Suggested change
| // We use this regex to support queries of the from "8atom", "6.5stake", | |
| // We use this regex to support queries of the form "8atom", "6.5stake", |
There was a problem hiding this comment.
I believe this behavior should be deprecated. If a unit must be specified, it should be in another field of the query.
in any case, the deprecation should happen in main, not here.
There was a problem hiding this comment.
Let's discuss this when @jmalicevic is back.
Co-authored-by: Lasaro <lasaro@informal.systems>
sergio-mena
approved these changes
May 17, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #797 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com