Rephrase log when committed TX not in local mempool + make it debug #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanz
approved these changes
Apr 20, 2023
mempool/clist_mempool.go
Outdated
| @@ -612,7 +612,7 @@ func (mem *CListMempool) Update( | |||
| // 100 | |||
| // https://github.com/tendermint/tendermint/issues/3322. | |||
| if err := mem.RemoveTxByKey(tx.Key()); err != nil { | |||
| mem.logger.Error("Committed transaction could not be removed from mempool", "key", tx.Key(), err.Error()) | |||
| mem.logger.Debug("Committed transaction not in local mempool (not an error)", "key", tx.Key(), err.Error()) | |||
There was a problem hiding this comment.
LGTM. Something that was missing in the previous PR, and that we can fix here, is to add a tag before err.Error(). For example: "error", err.Error(), or some other name.
There was a problem hiding this comment.
Well spotted! Fixed it
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
…738) Closes #737 If the execution hits the log line changed in this PR, it doesn't mean there is an error condition. A TX included in a block does not need to be present in the local mempool of a nodes at the time it is processing the new block. As the info is still useful, we re-word the message and turn it into a Debug log --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit 6498d67)
sergio-mena
added a commit
that referenced
this pull request
Apr 24, 2023
…738) (#749) Closes #737 If the execution hits the log line changed in this PR, it doesn't mean there is an error condition. A TX included in a block does not need to be present in the local mempool of a nodes at the time it is processing the new block. As the info is still useful, we re-word the message and turn it into a Debug log --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit 6498d67) Co-authored-by: Sergio Mena <sergio@informal.systems>
thanethomson
pushed a commit
that referenced
this pull request
May 6, 2023
…738) Closes #737 If the execution hits the log line changed in this PR, it doesn't mean there is an error condition. A TX included in a block does not need to be present in the local mempool of a nodes at the time it is processing the new block. As the info is still useful, we re-word the message and turn it into a Debug log --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #737
If the execution hits the log line changed in this PR, it doesn't mean there is an error condition.
A TX included in a block does not need to be present in the local mempool of a nodes at the time it is processing the new block.
As the info is still useful, we re-word the message and turn it into a Debug log
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments