cometbft · andynog · Sep 20, 2024 · Sep 19, 2024 · Sep 19, 2024 · Sep 19, 2024
@@ -0,0 +1,2 @@
+- `[log]` Change "mempool is full" log to debug level
+  ([\#4123](https://github.com/cometbft/cometbft/pull/4123))
@@ -364,7 +364,8 @@ func (mem *CListMempool) handleCheckTxResponse(tx types.Tx, sender p2p.ID) func(
 		// Check again that mempool isn't full, to reduce the chance of exceeding the limits.
 		if err := mem.isFull(len(tx)); err != nil {
 			mem.forceRemoveFromCache(tx) // mempool might have space later
-			mem.logger.Error(err.Error())
+			// use debug level to avoid spamming logs when traffic is high
+			mem.logger.Debug(err.Error())
 			mem.metrics.RejectedTxs.Add(1)
 			return err
 		}

@@ -172,12 +172,16 @@ func (memR *Reactor) TryAddTx(tx types.Tx, sender p2p.Peer) (*abcicli.ReqRes, er
 	}
 
 	reqRes, err := memR.mempool.CheckTx(tx, senderID)
-	switch {
-	case errors.Is(err, ErrTxInCache):
-		memR.Logger.Debug("Tx already exists in cache", "tx", log.NewLazySprintf("%X", tx.Hash()), "sender", senderID)
-		return nil, err
-	case err != nil:
-		memR.Logger.Info("Could not check tx", "tx", log.NewLazySprintf("%X", tx.Hash()), "sender", senderID, "err", err)
+	if err != nil {
+		switch {
+		case errors.Is(err, ErrTxInCache):
+			memR.Logger.Debug("Tx already exists in cache", "tx", log.NewLazySprintf("%X", tx.Hash()), "sender", senderID)
+		case errors.As(err, &ErrMempoolIsFull{}):
+			// using debug level to avoid flooding when traffic is high
+			memR.Logger.Debug(err.Error())
+		default:
+			memR.Logger.Info("Could not check tx", "tx", log.NewLazySprintf("%X", tx.Hash()), "sender", senderID, "err", err)
+		}
 		return nil, err
 	}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- `[log]` Change "mempool is full" log to debug level
		([\#4123](https://github.com/cometbft/cometbft/pull/4123))