8000 feat(mempool/metrics): Add new `evicted_txs` metric and call unused `rejected_txs` (backport #4019) by mergify[bot] · Pull Request #4051 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(mempool/metrics): Add new evicted_txs metric and call unused rejected_txs (backport #4019) #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2024
Merged

feat(mempool/metrics): Add new evicted_txs metric and call unused rejected_txs (backport #4019) #4051

merged 3 commits into from
Sep 10, 2024

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Sep 10, 2024

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
This is an automatic backport of pull request #4019 done by [Mergify](https://mergify.com).

@hvanz @mergify
feat(mempool/metrics): Add new evicted_txs metric and call unused `…
a39b575 
…rejected_txs` (#4019)

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [X] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 5e4ab3c)

# Conflicts:
#	docs/explanation/core/metrics.md
#	mempool/clist_mempool.go
@mergify mergify bot requested review from a team as code owners September 10, 2024 08:12
@mergify mergify bot added the conflicts label Sep 10, 2024
@mergify Mergify
Copy link
Contributor Author
mergify bot commented Sep 10, 2024

Cherry-pick of 5e4ab3c has failed:

On branch mergify/bp/v1.x/pr-4019
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit 5e4ab3c74.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changelog/unreleased/bug-fixes/4019-mempool-metric-rejected-txs.md
	new file:   .changelog/unreleased/improvements/4019-mempool-metric-evicted-txs.md
	modified:   mempool/metrics.gen.go
	modified:   mempool/metrics.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/explanation/core/metrics.md
	both modified:   mempool/clist_mempool.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned hvanz Sep 10, 2024
@hvanz hvanz removed the conflicts label Sep 10, 2024
@mergify mergify bot merged commit eaf664f into v1.x Sep 10, 2024
22 checks passed
@mergify mergify bot deleted the mergify/bp/v1.x/pr-4019 branch September 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvanz hvanz hvanz approved these changes

Assignees

@hvanz hvanz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hvanz
0