test(mempool): Add two Update benchmarks
#3873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results on |
Update benchmark testsUpdate benchmarks
melekes
approved these changes
Aug 27, 2024
| @@ -91,12 +91,6 @@ func (txs Txs) hashList() [][]byte { | |||
| // Txs is a slice of transactions. Sorting a Txs value orders the transactions | |||
| // lexicographically. | |||
|
|
|||
| func (txs Txs) Len() int { return len(txs) } | |||
There was a problem hiding this comment.
Go API break => we can't backport to v0.38.x
There was a problem hiding this comment.
Do we need this field only for this benchmark? If so, can we extract it somehow differently to not break APIs jsut for the sake of testing. If we are using it somewhere else in the mempool lanes work then this function should go together in a PR with where it is useful in production, not here.
There was a problem hiding this comment.
Or we can just leave it there for v0.38.x
There was a problem hiding this comment.
We can also mark these functions as deprecated (even in v0.38.x).
There was a problem hiding this comment.
Then we can leave them in 0.38.x, mark them as deprecated in v1.x and remove them later on.
jmalicevic
approved these changes
Aug 28, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Add new `BenchmarkUpdate` and `BenchmarkUpdateAndRecheck`. Also fix `BenchmarkCheckDuplicateTx`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 27a4606) # Conflicts: # mempool/clist_mempool_test.go # mempool/reactor_test.go
3 tasks
|
@Mergifyio backport v0.38.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Add new `BenchmarkUpdate` and `BenchmarkUpdateAndRecheck`. Also fix `BenchmarkCheckDuplicateTx`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 27a4606) # Conflicts: # mempool/bench_test.go # mempool/clist_mempool_test.go # mempool/reactor_test.go # types/tx.go
3 tasks
hvanz
added a commit
that referenced
this pull request
Sep 2, 2024
Add new `BenchmarkUpdate` and `BenchmarkUpdateAndRecheck`. Also fix `BenchmarkCheckDuplicateTx`. --- - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Sep 2, 2024
Add new `BenchmarkUpdate` and `BenchmarkUpdateAndRecheck`. Also fix `BenchmarkCheckDuplicateTx`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #3873 done by [Mergify](https://mergify.com). Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Sep 2, 2024
Add new `BenchmarkUpdate` and `BenchmarkUpdateAndRecheck`. Also fix `BenchmarkCheckDuplicateTx`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #3873 done by [Mergify](https://mergify.com). Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 1013c80)
3 tasks
mergify bot
added a commit
that referenced
this pull request
Sep 2, 2024
Add new `BenchmarkUpdate` and `BenchmarkUpdateAndRecheck`. Also fix `BenchmarkCheckDuplicateTx`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #3873 done by [Mergify](https://mergify.com). --------- Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
hvanz
pushed a commit
that referenced
this pull request
Sep 2, 2024
…3892) (#3957) Add new `BenchmarkUpdate` and `BenchmarkUpdateAndRecheck`. Also fix `BenchmarkCheckDuplicateTx`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #3873 done by [Mergify](https://mergify.com).<hr>This is an automatic backport of pull request #3892 done by [Mergify](https://mergify.com). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
BenchmarkUpdateandBenchmarkUpdateAndRecheck.Also fix
BenchmarkCheckDuplicateTx.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments