8000 Docs fixes (backport #368) by mergify[bot] · Pull Request #373 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Docs fixes (backport #368) #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 23, 2023
Merged

Docs fixes (backport #368) #373

merged 10 commits into from
Feb 23, 2023

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Feb 22, 2023

This is an automatic backport of pull request #368 done by Mergify.
Cherry-pick of 28baba3 has failed:

On branch mergify/bp/v0.34.x/pr-368
Your branch is up to date with 'origin/v0.34.x'.

You are currently cherry-picking commit 28baba3ed.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/app-dev/README.md
	modified:   docs/introduction/quick-start.md
	modified:   docs/qa/README.md
	renamed:    docs/qa/v034/CometBFT.md -> docs/qa/v034/README.md
	modified:   docs/qa/v034/TMCore.md
	modified:   docs/tools/README.md
	modified:   docs/tutorials/README.md
	new file:   rpc/openapi/README.md
	renamed:    rpc/openapi/index.html -> rpc/openapi/rpc.html
	modified:   spec/consensus/evidence.md
	modified:   spec/consensus/light-client/README.md
	modified:   spec/consensus/signing.md
	modified:   spec/core/data_structures.md
	modified:   spec/core/encoding.md
	modified:   spec/core/genesis.md
	modified:   spec/core/state.md

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   docs/core/rpc.md
	both modified:   docs/tools/debugging.md
	both modified:   docs/tutorials/go-built-in.md
	both modified:   docs/tutorials/go.md
	both modified:   spec/abci/README.md
	deleted by us:   spec/abci/abci++_basic_concepts.md
	deleted by us:   spec/abci/abci++_client_server.md
	deleted by us:   spec/abci/abci++_methods.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fixing broken link quick-start (#319)

* fix link to point to relative page (#319)

* fix link to point to rpc page (#319)

* fix link that works for rpc (#319)

* adding front matter to trigger hooks (#319)

* add frontmatter to adr page (#319)

* make link to configuration page relative (#319)

* remove irrelevant text (#319)

* updating relative link and removing irrelevant text (#319)

* remove front matter from ADR (#319)

* fixing broken links unders docs/tools (#319)

* fixing broken links under spec/core (#319)

* fixing broken links in spec/abci home (#319)

* fix uparrows rendering and broken links (#319)

* fixing links, comments on abci methods (#319)

* fixing links in tutorials (#319)

* adding a landing page for Apps (#319)

* renaming qa v0.34 page to show in navigation (#319)

* rename title of page for navigation (#319)

* fixing links on abci client server (#319)

* changes to allow RPC top level navigation on docs site (#319)

* fixing some more broken references (#319)

* reverting link change as per review (#319)

* reverting link change as per review (#319)

* reverting link in app-dev as per review (#319)

(cherry picked from commit 28baba3)

# Conflicts:
#	docs/core/rpc.md
#	docs/tools/debugging.md
#	docs/tutorials/go-built-in.md
#	docs/tutorials/go.md
#	spec/abci/README.md
#	spec/abci/abci++_basic_concepts.md
#	spec/abci/abci++_client_server.md
#	spec/abci/abci++_methods.md
@mergify mergify bot requested review from a team as code owners February 22, 2023 22:23
@mergify mergify bot added the conflicts label Feb 22, 2023
@adizere
Copy link
Member
adizere comm 8000 ented Feb 23, 2023

Gave it a stab at fixing the conflicts. e710a9a..dfbfca5

This one was not as easy as the other backport #372. Mainly because of the ABCI++ documentation that was not necessary here, so I deleted it, specifically these files

	deleted by us:   spec/abci/abci++_basic_concepts.md
	deleted by us:   spec/abci/abci++_client_server.md
	deleted by us:   spec/abci/abci++_methods.md

Hope it was the right thing, pls review!

Copy link
Contributor
@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor adaptations for this branch are needed.

@andynog
Copy link
Contributor
andynog commented Feb 23, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor Author
mergify bot commented Feb 23, 2023

refresh

✅ Pull request refreshed

@andynog andynog removed their assignment Feb 23, 2023
@andynog andynog self-requested a review February 23, 2023 19:34
Copy link
Contributor
@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in a good state to merge

Copy link
Contributor
@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andynog andynog merged commit c9f6511 into v0.34.x Feb 23, 2023
@andynog andynog deleted the mergify/bp/v0.34.x/pr-368 branch February 23, 2023 22:08
cason pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0