8000 revert(types): Revert #3543 (backport #3549) by alesforz · Pull Request #3705 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

revert(types): Revert #3543 (backport #3549) #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 15, 2024
Merged

revert(types): Revert #3543 (backport #3549) #3705

merged 4 commits into from
Aug 15, 2024

Conversation

alesforz
Copy link
Contributor
@alesforz alesforz commented Aug 14, 2024 •
edited
Loading

Given the discussion in #3528, we are reverting the changes made by #3543 in v0.38.x (backported with #3549).
Additionally, we are removing the changes made in #3543 from the CHANGELOG.

PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
- [] Updated relevant documentation (docs/ or spec/) and code comments

@alesforz
Revert "fix(types): Add missing JSON tags to DuplicateVoteEvidence …
2f03381 
…and `LightClientAttackEvidence` types (backport #3543) (#3549)"

This reverts commit 24b39c5.
@alesforz alesforz self-assigned this Aug 14, 2024
@alesforz alesforz marked this pull request as ready for review August 14, 2024 16:49
@alesforz alesforz requested a review from a team as a code owner August 14, 2024 16:49
@alesforz alesforz requested a review from sergio-mena August 14, 2024 16:49
@alesforz alesforz changed the title Fix(types): Revert #3543 (backport #3549) Revert(types): Revert #3543 (backport #3549) Aug 14, 2024
@sergio-mena sergio-mena changed the title Revert(types): Revert #3543 (backport #3549) revert(types): Revert #3543 (backport #3549) Aug 14, 2024
sergio-mena
sergio-mena previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor
@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@sergio-mena sergio-mena dismissed their stale review August 14, 2024 17:08

realised something last minute

sergio-mena
sergio-mena reviewed Aug 14, 2024
View reviewed changes
sergio-mena
sergio-mena approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor
@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment

melekes
melekes approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor
@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alesforz
Revert "removed lined in the CHANGELOG mentioning the changes", becau…
498c813 
…se the CHANGELOG

will update automatically with the next point release.

This reverts commit ece7c8e.
@alesforz alesforz merged commit b55fa31 into v0.38.x Aug 15, 2024
21 checks passed
@alesforz alesforz deleted the alesforz/v0.38.x/revert-pr-3543 branch August 15, 2024 07:09
@faddat faddat mentioned this pull request Oct 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already h 6A1C ave an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@sergio-mena sergio-mena sergio-mena approved these changes

Assignees

@alesforz alesforz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alesforz @melekes @sergio-mena
0