8000 build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.3 to 2.3.4 by dependabot[bot] · Pull Request #3531 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.3 to 2.3.4 #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.3 to 2.3.4 #3531

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor
@dependabot dependabot bot commented on behalf of github Jul 22, 2024

Bumps github.com/btcsuite/btcd/btcec/v2 from 2.3.3 to 2.3.4.

Commits
  • ff2e03e chore: fix some comments for struct field (#2214)
  • 2134387 Merge pull request #2208 from kcalvinalvin/2024-07-01-close-blockfiles
  • e5d15fd btcec/ecdsa: remove error return value for SignCompact (#2211)
  • c9fae1a ffldb: close block files before deleting them
  • 8ed8ef1 ffldb: refactor out file close code into its own method
  • 8b5f2aa ffldb: add check for deleting files that are open
  • 4712e20 ffldb: throw error when attempting to delete an open file
  • d881c68 Fix the btcctl uptime command
  • 1396690 Sending RPC requests through unix sockets (#2168)
  • b2eec96 Merge pull request #2206 from guggero/psbt-serialization-fix
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show al 8000 l of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
build(deps): Bump github.com/btcsuite/btcd/btcec/v2 from 2.3.3 to 2.3.4
31708dd 
Bumps [github.com/btcsuite/btcd/btcec/v2](https://github.com/btcsuite/btcd) from 2.3.3 to 2.3.4.
- [Release notes](https://github.com/btcsuite/btcd/releases)
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES)
- [Commits](btcsuite/btcd@btcec/v2.3.3...btcec/v2.3.4)

---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd/btcec/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested review from a team as code owners July 22, 2024 04:05
@dependabot dependabot bot added automerge dependencies Dependency updates labels Jul 22, 2024
@sergio-mena
Copy link
Contributor

Can't be automatically applied, as it breaks the build

@dependabot Dependabot
Copy link
Contributor Author
dependabot bot commented on 8000 behalf of github Jul 22, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/main/github.com/btcsuite/btcd/btcec/v2-2.3.4 branch July 22, 2024 08:56
@sigv sigv mentioned this pull request Aug 18, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
@sigv @mergify
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (#3728)
17abb80 
Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot pushed a commit that referenced this pull request Aug 19, 2024
@sigv @mergify
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (#3728)
ab1209f 
Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 17abb80)

# Conflicts:
#	crypto/secp256k1/secp256k1.go
@mergify mergify bot mentioned this pull request Aug 19, 2024
Merged
3 tasks
melekes added a commit that referenced this pull request Aug 19, 2024
@mergify @sigv @melekes
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (backport #3728) (…
6e04855 
…#3755)

Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments<hr>This is an automatic backport of pull request #3728 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Valters Jansons <sigv@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
@sigv @mergify
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (#3728)
0ede74b 
Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 17abb80)

# Conflicts:
#	crypto/secp256k1/secp256k1.go
#	go.mod
#	go.sum
@mergify mergify bot mentioned this pull request Aug 20, 2024
Merged
3 tasks
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
@sigv @mergify
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (#3728)
aebd094 
Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 17abb80)

# Conflicts:
#	crypto/secp256k1/secp256k1.go
#	go.mod
#	go.sum
@mergify mergify bot mentioned this pull request Aug 20, 2024
Merged
3 tasks
melekes added a commit that referenced this pull request Aug 20, 2024
@mergify @sigv @melekes
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (backport #3728) (…
01ee8c4 
…#3758)

Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments<hr>This is an automatic backport of pull request #3728 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Valters Jansons <sigv@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mergify bot added a commit that referenced this pull request Aug 20, 2024
@mergify
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (backport #3728) (…
51af4ac 
…#3758)

Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments<hr>This is an automatic backport of pull request #3728 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Valters Jansons <sigv@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
(cherry picked from commit 01ee8c4)

# Conflicts:
#	go.mod
#	go.sum
@mergify mergify bot mentioned this pull request Aug 20, 2024
Merged
3 tasks
melekes added a commit that referenced this pull request Aug 20, 2024
@mergify @sigv @melekes
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (backport #3728) (…
8d45fb0 
…#3759)

Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments<hr>This is an automatic backport of pull request #3728 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Valters Jansons <sigv@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
mergify bot added a commit that referenced this pull request Aug 22, 2024
@mergify
build(crypto/secp256k1): Update btcec/v2 to v2.3.4 (backport #3728)…
e4cd1f4 
… (backport #3758) (#3808)

Running a `go get` should consistently build this project as per the
README. However, the latest patch release of `btcec/v2` is not a proper
Semantic Versioning patch. It removes an error return value from
`ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is
functionally a no-op, as the underlying function was hardcoded to always
return `nil` as error. However, this is still a breaking change
(compiler/build error) for all consumers of this function, as they
historically expected two return values, but now only get one.

Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments<hr>This is an automatic backport of pull request #3728 done by
[Mergify](https://mergify.com).<hr>This is an automatic backport of pull
request #3758 done by [Mergify](https://mergify.com).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge dependencies Dependency updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sergio-mena
0