Nenad/150 abci spec fixes (backport #210) #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Text fixed -"Methods" section fixed to consider locked value. * File with extra scenarios added * Text fixed to not mention locked value * Grammar fixed * Update spec/abci/abci++_extra.md * Update spec/abci/abci++_extra.md * Update spec/abci/abci++_extra.md * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md Co-authored-by: Sergio Mena <sergio@informal.systems> * Update spec/abci/abci++_extra.md * Update spec/abci/abci++_methods.md * file with scenarios integrated * renaming Tendermint->CometBFT done * Apply suggestions from code review Co-authored-by: Daniel <daniel.cason@informal.systems> * Fixed PR's comments: -fixed daniel's and lasaro's comments -renamed abci++_tmint_expected_behavior.md to abci++_comet_expected_behavior.md --------- Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 6ab7d28)
cason
approved these changes
Feb 16, 2023
noot
pushed a commit
to astriaorg/cometbft
that referenced
this pull request
Jun 14, 2023
* Typo fix in README.md (cometbft#350) * Updated Apalache type annotations (cometbft#395) Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com> Co-authored-by: Kukovec <jure.kukovec@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #210 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com