fix(indexer): Ineffective or missing break statements in kv package. #3557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c69acd5 to
471ec5e
Compare
sergio-mena
reviewed
Jul 25, 2024
.changelog/unreleased/bug-fixes/3544-indexer-break-statement.md
Outdated
Show resolved
Hide resolved
sergio-mena
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
The breaks you've modified LGTM. The breaks you've introduced also LGTM, but I have less confidence on my review there.
I'd wait for @jmalicevic to take a quick look at those introduced break statements.
Co-authored-by: Sergio Mena <sergio@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
…3557) Closes #3544. ### Changes - Adds missing `for` loop labels in the kv indexer - Previously ineffective `break` statements now point to their enclosing `for` loop labels to exit upon reception on the `ctx.Done()` channel. --- #### PR checklist ~- [ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 79da036) # Conflicts: # state/indexer/block/kv/kv.go
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
…3557) Closes #3544. ### Changes - Adds missing `for` loop labels in the kv indexer - Previously ineffective `break` statements now point to their enclosing `for` loop labels to exit upon reception on the `ctx.Done()` channel. --- #### PR checklist ~- [ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored- 8000 by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 79da036) # Conflicts: # state/indexer/block/kv/kv.go
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
…3557) Closes #3544. ### Changes - Adds missing `for` loop labels in the kv indexer - Previously ineffective `break` statements now point to their enclosing `for` loop labels to exit upon reception on the `ctx.Done()` channel. --- #### PR checklist ~- [ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit 79da036)
This was referenced Jul 26, 2024
alesforz
added a commit
that referenced
this pull request
Jul 26, 2024
…(backport #3557) (#3562) Closes #3544. ### Changes - Adds missing `for` loop labels in the kv indexer - Previously ineffective `break` statements now point to their enclosing `for` loop labels to exit upon reception on the `ctx.Done()` channel. --- #### PR checklist ~- [ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3557 done by [Mergify](https://mergify.com). Co-authored-by: Alessandro Sforzin <alessandro@informal.systems>
alesforz
added a commit
that referenced
this pull request
Jul 26, 2024
…(backport #3557) (#3564) Closes #3544. ### Changes - Adds missing `for` loop labels in the kv indexer - Previously ineffective `break` statements now point to their enclosing `for` loop labels to exit upon reception on the `ctx.Done()` channel. --- #### PR checklist ~- [ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3557 done by [Mergify](https://mergify.com). --------- Co-authored-by: Alessandro <alessandro@informal.systems>
alesforz
added a commit
that referenced
this pull request
Jul 26, 2024
…(backport #3557) (#3563) Closes #3544. ### Changes - Adds missing `for` loop labels in the kv indexer - Previously ineffective `break` statements now point to their enclosing `for` loop labels to exit upon reception on the `ctx.Done()` channel. --- #### PR checklist ~- [ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3557 done by [Mergify](https://mergify.com). --------- Co-authored-by: Alessandro <alessandro@informal.systems>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3544.
Changes
forloop labels in the kv indexerbreakstatements now point to their enclosingforloop labels to exit upon reception on thectx.Done()channel.PR checklist
- [ ] Tests written/updated.changelog(we use unclog to manage our changelog)- [ ] Updated relevant documentation (docs/orspec/) and code comments