fix(mempool): wrong request type when rechecking #3264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
zsystm
added a commit
to b-harvest/minievm
that referenced
this pull request
Jul 9, 2024
current version of cometbft which minievm uses have a bug(cometbft/cometbft#3264 (comment)) which makes transaction broadcasting unavailable.
beer-1
pushed a commit
to initia-labs/minievm
that referenced
this pull
8000
request
Jul 10, 2024
* feat: new eth apis, refactor: code structures new eth apis - GetStorageAt - GetCode refactor - Restricted the scope of access for each namespace API (instead of accessing the backend directly, now access is through a scoped wrapper) - Also renamed files and repositioned some methods within the backend directory to better reflect their purpose * fix: not implemented txpool api temp disable txpool api because we don't have any implementation * fix: change event type for extract logs * add cap for filters * add filter system and apis * fix comment Co-authored-by: zsystm <124245155+zsystm@users.noreply.github.com> * delete unused interfaces and comments * fix varible and function naming * add TODO comments * delete unused functions * add error handling * Set websocket params to prevent timeout * fix: change GetLogsByHeight interface * chore: change variable names from tm to comet * docs: add comments about websocket client params * fix: go.mod and go.work.sum ran the followings for this commit: - go mod tidy - go work sync * update: cometbft dep current version of cometbft which minievm uses have a bug(cometbft/cometbft#3264 (comment)) which makes transaction broadcasting unavailable. --------- Co-authored-by: jason song <jason.song@bharvest.io> Co-authored-by: jasonsong0 <96075298+jasonsong0@users.noreply.github.com>
beer-1
added a commit
to initia-labs/minievm
that referenced
this pull request
Jul 12, 2024
* wip * wip2 * feat: json-rpc signing * direction * add indexer * enable jsonrpc * add precision checking logic * fix test * reterive value from the msg * fix: handle unit conversion in cosmos to ethereum tx (#24) whenever ethereum tx is converted into cosmos tx by ConvertEthereumTxToCosmosTx, the value is converted to cosmos fee unit from wei. so when convert the cosmos tx to back the original ethereum tx, we should convert the value back to wei to get original ethereum tx. * fix pubkey recover * fix test * feat: implement new apis and refactoring (#28) * feat: new eth apis, refactor: code structures new eth apis - GetStorageAt - GetCode refactor - Restricted the scope of access for each namespace API (instead of accessing the backend directly, now access is through a scoped wrapper) - Also renamed files and repositioned some methods within the backend directory to better reflect their purpose * fix: not implemented txpool api temp disable txpool api because we don't have any implementation * fix: change event type for extract logs * add cap for filters * add filter system and apis * fix comment Co-authored-by: zsystm <124245155+zsystm@users.noreply.github.com> * delete unused interfaces and comments * fix varible and function naming * add TODO comments * delete unused functions * add error handling * Set websocket params to prevent timeout * fix: change GetLogsByHeight interface * chore: change variable names from tm to comet * docs: add comments about websocket client params * fix: go.mod and go.work.sum ran the followings for this commit: - go mod tidy - go work sync * update: cometbft dep current version of cometbft which minievm uses have a bug(cometbft/cometbft#3264 (comment)) which makes transaction broadcasting unavailable. --------- Co-authored-by: jason song <jason.song@bharvest.io> Co-authored-by: jasonsong0 <96075298+jasonsong0@users.noreply.github.com> * feat: directly subscribe logs from indexer (#34) * change filter system to directly subscribe from indexer * use mutex and pass logs in bulk * fix dependency problems * add readme * update readme --------- Co-authored-by: suha jin <89185836+djm07073@users.noreply.github.com> Co-authored-by: zsystm <124245155+zsystm@users.noreply.github.com> Co-authored-by: jason song <jason.song@bharvest.io> Co-authored-by: jasonsong0 <96075298+jasonsong0@users.noreply.github.com>
beer-1
added a commit
to initia-labs/evm-contracts
that referenced
this pull request
Jul 18, 2024
* wip * wip2 * feat: json-rpc signing * direction * add indexer * enable jsonrpc * add precision checking logic * fix test * reterive value from the msg * fix: handle unit conversion in cosmos to ethereum tx (#24) whenever ethereum tx is converted into cosmos tx by ConvertEthereumTxToCosmosTx, the value is converted to cosmos fee unit from wei. so when convert the cosmos tx to back the original ethereum tx, we should convert the value back to wei to get original ethereum tx. * fix pubkey recover * fix test * feat: implement new apis and refactoring (#28) * feat: new eth apis, refactor: code structures new eth apis - GetStorageAt - GetCode refactor - Restricted the scope of access for each namespace API (instead of accessing the backend directly, now access is through a scoped wrapper) - Also renamed files and repositioned some methods within the backend directory to better reflect their purpose * fix: not implemented txpool api temp disable txpool api because we don't have any implementation * fix: change event type for extract logs * add cap for filters * add filter system and apis * fix comment Co-authored-by: zsystm <124245155+zsystm@users.noreply.github.com> * delete unused interfaces and comments * fix varible and function naming * add TODO comments * delete unused functions * add error handling * Set websocket params to prevent timeout * fix: change GetLogsByHeight interface * chore: change variable names from tm to comet * docs: add comments about websocket client params * fix: go.mod and go.work.sum ran the followings for this commit: - go mod tidy - go work sync * update: cometbft dep current version of cometbft which minievm uses have a bug(cometbft/cometbft#3264 (comment)) which makes transaction broadcasting unavailable. --------- Co-authored-by: jason song <jason.song@bharvest.io> Co-authored-by: jasonsong0 <96075298+jasonsong0@users.noreply.github.com> * feat: directly subscribe logs from indexer (#34) * change filter system to directly subscribe from indexer * use mutex and pass logs in bulk * fix dependency problems * add readme * update readme --------- Co-authored-by: suha jin <89185836+djm07073@users.noreply.github.com> Co-authored-by: zsystm <124245155+zsystm@users.noreply.github.com> Co-authored-by: jason song <jason.song@bharvest.io> Co-authored-by: jasonsong0 <96075298+jasonsong0@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3261
This bug only affects
v0.38.x.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments