8000 QA: v0.34 - 1/3 TM 2/3 CMT by lasarojc · Pull Request #297 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

QA: v0.34 - 1/3 TM 2/3 CMT #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Feb 15, 2023
Merged

QA: v0.34 - 1/3 TM 2/3 CMT #297

merged 31 commits into from
Feb 15, 2023

Conversation

lasarojc
Copy link
Contributor
@lasarojc lasarojc commented Feb 9, 2023

Contributes to #283

@lasarojc lasarojc requested a review from a team as a code owner February 9, 2023 16:07
@lasarojc lasarojc self-assigned this Feb 9, 2023
@lasarojc lasarojc marked this pull request as draft February 9, 2023 16:07
@lasarojc lasarojc added the qa Quality assurance label Feb 9, 2023
@lasarojc lasarojc mentioned this pull request Feb 9, 2023
8 tasks
@lasarojc lasarojc force-pushed the lasarojc/0.34-qa-tm1cmt2 branch from 0c4c5b3 to 6f204f4 Compare February 9, 2023 18:12
Copy link
Contributor
@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lásaro! In particular for the new, better way of producing the Prometheus plots.
Some of the plots seem to start some time before the experiment. Although I agree it can be interesting to see how the system goes from idle to busy, it adds some noise when comparing them with existing reports (baseline, v0.37.x). The main criterion for PASS or FAIL is how similar new plots are to existing ones.

@sergio-mena sergio-mena added the rename Renaming our fork label Feb 10, 2023
@lasarojc lasarojc marked this pull request as ready for review February 10, 2023 12:56
lasarojc and others added 4 commits February 10, 2023 22:16
* Changes to homogeneous results. First version

* Tweak to plotting script

* Revert "Tweak to plotting script"

* Updated homogeneous text and script

* Splitting the README.md

* Updating the instructions to plotters

* Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text

* Final plots for homogeneous

* Extracted and added baseline data (oct 2022) to the report

* Polishing the text

* Removed two unsued .png files

* Rename homogeneous latencies

---------

Co-authored-by: Lasaro <lasaro@informal.systems>
…emoving files not needed. Reorganizing some sections of the report
@lasarojc lasarojc force-pushed the lasarojc/0.34-qa-tm1cmt2 branch from 3385306 to 805143c Compare February 14, 2023 11:26
@lasarojc lasarojc merged commit 2ccf684 into main Feb 15, 2023
@lasarojc lasarojc deleted the lasarojc/0.34-qa-tm1cmt2 branch February 15, 2023 12:47
@lasarojc lasarojc added backport-to-v0.34.x Tell Mergify to backport the PR to v0.34.x backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x labels Feb 15, 2023
mergify bot pushed a commit that referenced this pull request Feb 15, 2023
* adding the 2/3 comet 1/3 tm case, without explanations

* moving experiment to folder to standardize names

* Description of how to run the prometheus plotter file

* regenerating figures and deleting the old ones

* moving the reporting scripts to this repo

* Updating CMT1/3 TM2/3 latency figures

* Updating prometheus metrics for cmt1 tm2 case

* Updating scripts

* extending the window to capture the long tail of experiments

* improved plotter, let's you include the average in the graph

* Updating prometheus metrics for cmt1 tm2 case

* Revert to referencing TM where it makes sense

* Updating prometheus metrics for cmt2 tm1 case

* Updating prometheus metrics for cmt2 tm1 case and references in the README.

* Updating prometheus metrics for cmt1 tm2 case

* Fixing section levels. Changed results to table

* reducing time window to 20s

* reducing time window to 20s

* Start splitting the files

* reducing time window to 20s in the script

* Update the data and comments for homogeneous network (#312)

* Changes to homogeneous results. First version

* Tweak to plotting script

* Revert "Tweak to plotting script"

* Updated homogeneous text and script

* Splitting the README.md

* Updating the instructions to plotters

* Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text

* Final plots for homogeneous

* Extracted and added baseline data (oct 2022) to the report

* Polishing the text

* Removed two unsued .png files

* Rename homogeneous latencies

---------

Co-authored-by: Lasaro <lasaro@informal.systems>

* making file names consitent with script output and across sections. Removing files not needed. Reorganizing some sections of the report

* Plot to the imgs folder. Don't block between plots.

* Adding report for half-half configuration. Update scripts include the test.

* Fix typo in the `requirements.txt` file.
Expand the explantion of the `latency_plotter.py` script

* Moving instructions to run  to the reporting

* Small tweaks in the text

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit 2ccf684)
mergify bot pushed a commit that referenced this pull request Feb 15, 2023
* adding the 2/3 comet 1/3 tm case, without explanations

* moving experiment to folder to standardize names

* Description of how to run the prometheus plotter file

* regenerating figures and deleting the old ones

* moving the reporting scripts to this repo

* Updating CMT1/3 TM2/3 latency figures

* Updating prometheus metrics for cmt1 tm2 case

* Updating scripts

* extending the window to capture the long tail of experiments

* improved plotter, let's you include the average in the graph

* Updating prometheus metrics for cmt1 tm2 case

* Revert to referencing TM where it makes sense

* Updating prometheus metrics for cmt2 tm1 case

* Updating prometheus metrics for cmt2 tm1 case and references in the README.

* Updating prometheus metrics for cmt1 tm2 case

* Fixing section levels. Changed results to table

* reducing time window to 20s

* reducing time window to 20s

* Start splitting the files

* reducing time window to 20s in the script

* Update the data and comments for homogeneous network (#312)

* Changes to homogeneous results. First version

* Tweak to plotting script

* Revert "Tweak to plotting script"

* Updated homogeneous text and script

* Splitting the README.md

* Updating the instructions to plotters

* Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text

* Final plots for homogeneous

* Extracted and added baseline data (oct 2022) to the report

* Polishing the text

* Removed two unsued .png files

* Rename homogeneous latencies

---------

Co-authored-by: Lasaro <lasaro@informal.systems>

* making file names consitent with script output and across sections. Removing files not needed. Reorganizing some sections of the report

* Plot to the imgs folder. Don't block between plots.

* Adding report for half-half configuration. Update scripts include the test.

* Fix typo in the `requirements.txt` file.
Expand the explantion of the `latency_plotter.py` script

* Moving instructions to run  to the reporting

* Small tweaks in the text

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit 2ccf684)

# Conflicts:
#	docs/qa/README.md
lasarojc added a commit that referenced this pull request Feb 15, 2023
* adding the 2/3 comet 1/3 tm case, without explanations

* moving experiment to folder to standardize names

* Description of how to run the prometheus plotter file

* regenerating figures and deleting the old ones

* moving the reporting scripts to this repo

* Updating CMT1/3 TM2/3 latency figures

* Updating prometheus metrics for cmt1 tm2 case

* Updating scripts

* extending the window to capture the long tail of experiments

* improved plotter, let's you include the average in the graph

* Updating prometheus metrics for cmt1 tm2 case

* Revert to referencing TM where it makes sense

* Updating prometheus metrics for cmt2 tm1 case

* Updating prometheus metrics for cmt2 tm1 case and references in the README.

* Updating prometheus metrics for cmt1 tm2 case

* Fixing section levels. Changed results to table

* reducing time window to 20s

* reducing time window to 20s

* Start splitting the files

* reducing time window to 20s in the script

* Update the data and comments for homogeneous network (#312)

* Changes to homogeneous results. First version

* Tweak to plotting script

* Revert "Tweak to plotting script"

* Updated homogeneous text and script

* Splitting the README.md

* Updating the instructions to plotters

* Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text

* Final plots for homogeneous

* Extracted and added baseline data (oct 2022) to the report

* Polishing the text

* Removed two unsued .png files

* Rename homogeneous latencies

---------

Co-authored-by: Lasaro <lasaro@informal.systems>

* making file names consitent with script output and across sections. Removing files not needed. Reorganizing some sections of the report

* Plot to the imgs folder. Don't block between plots.

* Adding report for half-half configuration. Update scripts include the test.

* Fix typo in the `requirements.txt` file.
Expand the explantion of the `latency_plotter.py` script

* Moving instructions to run  to the reporting

* Small tweaks in the text

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit 2ccf684)

Co-authored-by: Lasaro <lasaro@informal.systems>
lasarojc added a commit that referenced this pull request Feb 15, 2023
* adding the 2/3 comet 1/3 tm case, without explanations

* moving experiment to folder to standardize names

* Description of how to run the prometheus plotter file

* regenerating figures and deleting the old ones

* moving the reporting scripts to this repo

* Updating CMT1/3 TM2/3 latency figures

* Updating prometheus metrics for cmt1 tm2 case

* Updating scripts

* extending the window to capture the long tail of experiments

* improved plotter, let's you include the average in the graph

* Updating prometheus metrics for cmt1 tm2 case

* Revert to
6D47
 referencing TM where it makes sense

* Updating prometheus metrics for cmt2 tm1 case

* Updating prometheus metrics for cmt2 tm1 case and references in the README.

* Updating prometheus metrics for cmt1 tm2 case

* Fixing section levels. Changed results to table

* reducing time window to 20s

* reducing time window to 20s

* Start splitting the files

* reducing time window to 20s in the script

* Update the data and comments for homogeneous network (#312)

* Changes to homogeneous results. First version

* Tweak to plotting script

* Revert "Tweak to plotting script"

* Updated homogeneous text and script

* Splitting the README.md

* Updating the instructions to plotters

* Update the latency plotter to print the experiment times in UTC and update the reference to specific experiments in the text

* Final plots for homogeneous

* Extracted and added baseline data (oct 2022) to the report

* Polishing the text

* Removed two unsued .png files

* Rename homogeneous latencies

---------

Co-authored-by: Lasaro <lasaro@informal.systems>

* making file names consitent with script output and across sections. Removing files not needed. Reorganizing some sections of the report

* Plot to the imgs folder. Don't block between plots.

* Adding report for half-half configuration. Update scripts include the test.

* Fix typo in the `requirements.txt` file.
Expand the explantion of the `latency_plotter.py` script

* Moving instructions to run  to the reporting

* Small tweaks in the text

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit 2ccf684)

# Conflicts:
#	docs/qa/README.md

Co-authored-by: Lasaro <lasaro@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.34.x Tell Mergify to backport the PR to v0.34.x backport-to-v0.37.x Tell Mergify to backport the PR to v0.37.x qa Quality assurance rename Renaming our fork
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
0