refactor(crypto): handle errors and more in bls12381
#2832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pin cometbft-db-testing image version - extract const in a separate file - return err in GenPrivKey and NewPrivateKeyFromBytes
bls12381
sergio-mena
reviewed
Apr 18, 2024
sergio-mena
reviewed
Apr 18, 2024
| @@ -12,7 +12,62 @@ import ( | |||
| "github.com/cometbft/cometbft/crypto/bls12381" | |||
| ) | |||
|
|
|||
| func TestSignAndValidateBLS12381(t *testing.T) { | |||
| func TestNewPrivateKeyFromBytes(t *testing.T) { | |||
There was a problem hiding this comment.
I love these unit tests ❤️
Co-authored-by: Sergio Mena <sergio@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
- pin cometbft-db-testing image version - extract const in a separate file - return err in GenPrivKey and NewPrivateKeyFromBytes Follow-up to #2765 --- #### PR checklist - [x] Tests written/updated - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit d27732a)
4 tasks
melekes
added a commit
that referenced
this pull request
Apr 18, 2024
… (#2842) - pin cometbft-db-testing image version - extract const in a separate file - return err in GenPrivKey and NewPrivateKeyFromBytes Follow-up to #2765 --- #### PR checklist - [x] Tests written/updated - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2832 done by [Mergify](https://mergify.com). Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2765
PR checklist
Changelog entry added in.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments